Allow Stack to build using Common packages #7023
Merged
+2,330
−1,034,098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement are not running for a path length issue that I can't seem to resolve.
…age reference paths and renamed them all to be the same filename casing.
MiYanni
commented
Aug 23, 2018
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> | ||
| <None Include="..\..\Common\Commands.ScenarioTests.ResourceManager.Common\AzureRM.Resources.ps1"> | ||
| <!-- <None Include="..\..\Common\Commands.ScenarioTests.ResourceManager.Common\AzureRM.Resources.ps1"> |
| <package id="System.Spatial" version="5.8.2" targetFramework="net45" /> | ||
| <package id="WindowsAzure.ServiceBus" version="2.8.2" targetFramework="net45" /> | ||
| <package id="WindowsAzure.Storage" version="9.0.0" targetFramework="net452" /> | ||
| <package id="WindowsAzure.Storage" version="8.1.1" targetFramework="net452" /> |
Contributor
Author
There was a problem hiding this comment.
This was a bug I had from the Common PR.
| <HintPath>..\..\..\..\packages\Microsoft.Azure.Management.Storage.6.4.0-preview\lib\net452\Microsoft.Azure.Management.Storage.dll</HintPath> | ||
| </Reference> | ||
| --> | ||
| <!-- <Reference Include="Microsoft.Azure.Management.Storage, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> |
markcowl
requested changes
Aug 23, 2018
| @@ -4,6 +4,6 @@ | |||
| <package id="Microsoft.Data.Edm" version="5.6.4" targetFramework="net40" /> | |||
| <package id="Microsoft.Data.OData" version="5.6.4" targetFramework="net40" /> | |||
| <package id="Microsoft.Data.Services.Client" version="5.6.4" targetFramework="net40" /> | |||
| <package id="Microsoft.WindowsAzure.Management.Storage" version="5.1.1" targetFramework="net40" /> | |||
| <package id="Microsoft.WindowsAzure.Management.Storage" version="6.0.1" targetFramework="net40" /> | |||
Contributor
Author
There was a problem hiding this comment.
Nope. Changed it back and fixed a different packages.config issue.
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="Microsoft.WindowsAzure.Management.Storage"> | ||
| <HintPath>..\..\..\..\packages\Microsoft.WindowsAzure.Management.Storage.5.1.1\lib\net40\Microsoft.WindowsAzure.Management.Storage.dll</HintPath> |
Contributor
Author
There was a problem hiding this comment.
Not intentional. Set it back to 5.1.1.
…ded packages.config reference for WindowsAzure.Storage.
markcowl
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to Stack:
Stackdirectories intoStackAdminStack.slnintoStackAdminChecklist
CONTRIBUTING.mdplatyPSmodule