-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Azurestack admin module 1.2.12 migration guide #6156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 3. [Breaking changes in storage admin module](#Breaking-changes-in-storage-admin-module) | ||
|
|
||
| ## Summary | ||
| The module version 1.2.12 of AzureStack brings in many breaking changes. Most of these breaking changes were noted with warnings in the previous releases. Please note that there are no changes in the AzureRM version of the module specific to azure stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
azure stack -> Azure Stack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
| - Parameter ```Managed``` in Get-AzsOffer has been deprecated. Please use Get-AzsManagedOffer instead | ||
|
|
||
| **Flattening of Properties** <br> | ||
| The Plan/Offer/Subscription objects wont be having .Properties instead the child properties are flattened out to be at the Top level. If you are having any references to the .Properties, this breaking change could be fixed by accessing the prperty directly at the top level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Plan/Offer/Subscription objects have removed the intermediate Properties field, and child properties are moved to the top level. If you are having any references to Properties, this breaking change could be fixed by accessing the remove the intermediate Properties reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties field of the objects Plan, Offer, Subscription have been removed and the child properties are moved to the top level. If you are having any references to the Properties, this breaking change could be fixed by removing the intermediate Properties reference
| The pareamters ```MetricNames```, ```DetailedOutput``` have been removed for Get-Azs*MetricDefinition Cmdlets, please replace with Where-Object and Select-Object | ||
|
|
||
| **New Parameters** | ||
| - The parameter ```ResourceGroupName``` is now an optional for all cmdlets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except in subscriptions and AzureBridge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This talks about only the Storage admin module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Do we mention somewhere that all resource group names are optional except for those two? Also, how do users find those resource groups? I guess that is not for use to describe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think it needs to go in a separate doc, each cmdlet's reference doc should cover that
| - Start-AzsReclaimStorageCapacity | ||
|
|
||
|
|
||
| - ```ResourceId``` parameter can be used for cmdlets that require ```Name``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this? When I first read this I didn't understand right away. Also, you should mention this has an Alias for 'id'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a line. agreed this is confusing, will be better if we add an example. I think we will have to do that later. Unlike subscription module, storage module was not used extensively by the customer
| @@ -0,0 +1,113 @@ | |||
| # Table of Contents | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a list of known issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
known issues will be in the main documentation site. I think it makes sense to add it here as well. We can do that later. I still expect us to edit this for few details even after the release(like adding specific examples Old vs New )
|
@markcowl This should be good to merge. Thanks |
| Module Name: Azs.AzureBridge.Admin | ||
| Module Name: Azs.Azurebridge.Admin | ||
| Module Guid: 82d2260a-95ae-44bb-af8b-afd67d38f6db | ||
| Download Help Link: {{Please enter FwLink manually}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what this is. Maybe Thomas does?
| @@ -0,0 +1,112 @@ | |||
| # Table of Contents | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will wan to update the version numbers and name for this file
|
@markcowl pushed a commit to rename the file and the contents to 1.3.0 |
Azurestack admin module 1.2.12 migration guide
Description
Stack admin module migration guide.
Checklist
CONTRIBUTING.mdplatyPSmodule