Skip to content

Conversation

@huangpf
Copy link
Contributor

@huangpf huangpf commented Jul 10, 2015

  • Updated ServiceDefinition and ServiceConfiguration schema files to unblock deserialization
  • Updated Version number validation to relax constraint
  • Updated StorageEmulator invocation due to StorageEmulator executable rename

@azurecla
Copy link

Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (phuang). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, if key.GetSubKeyNames() is empty, Last() would throw exception. Would it be a concern?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Let me change that to LastOrDefault() so it won't throw when an item is not found.

@huangpf
Copy link
Contributor Author

huangpf commented Jul 10, 2015

LGTM.

hovsepm pushed a commit that referenced this pull request Jul 10, 2015
AzureRT PR S51 - Updating Start/Stop Emulator related cmdlets to work with latest .NET release
@hovsepm hovsepm merged commit 451d256 into Azure:dev Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants