Skip to content

Routes and other network changes from feedback #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markcowl merged 11 commits into from
Jul 13, 2015
Merged

Routes and other network changes from feedback #581

markcowl merged 11 commits into from
Jul 13, 2015

Conversation

@DeepakRajendranMsft
Copy link
Contributor

@DeepakRajendranMsft DeepakRajendranMsft commented Jul 10, 2015

Changes include:

  1. Add Routes and RouteTables
  2. Rename Get-AzureCheckDnsAvailability to Test-AzureDnsAvailability (from feedback)
  3. Minor loadbalancer bug
  4. Allow RequestPath in loadbalancer to be optional (from feedback)
  5. Tests

@azurecla
Copy link

azurecla commented Jul 10, 2015

Hi @DeepakRajendranMsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@DeepakRajendranMsft DeepakRajendranMsft changed the title [DO NOT MERGE] Routes and other network changes from feedback Routes and other network changes from feedback Jul 10, 2015
@markcowl
Copy link
Member

markcowl commented Jul 10, 2015

@DeepakRajendranMsft There are merge conflicts, please update

@DeepakRajendranMsft
Copy link
Contributor Author

DeepakRajendranMsft commented Jul 11, 2015

@markcowl Merged conflicts

markcowl
markcowl reviewed Jul 11, 2015
View reviewed changes
src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj Outdated
Copy link
Member

@markcowl markcowl Jul 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change

@markcowl
Copy link
Member

markcowl commented Jul 11, 2015

@DeepakRajendranMsft A couple of issues with csproj references to correct - otherwise looks good. Please correct and I'll merge

@DeepakRajendranMsft
Copy link
Contributor Author

DeepakRajendranMsft commented Jul 11, 2015

@markcowl reverted the csproj changes

@markcowl
Copy link
Member

markcowl commented Jul 13, 2015

@azuresdkci retest this please

markcowl added a commit that referenced this pull request Jul 13, 2015
@markcowl
Merge pull request #581 from DeepakRajendranMsft/Routes
38466d8 
Routes and other network changes from feedback
@markcowl markcowl merged commit 38466d8 into Azure:dev Jul 13, 2015
@DeepakRajendranMsft DeepakRajendranMsft deleted the Routes branch July 13, 2015 21:15
huangpf added a commit to AzureRT/azure-powershell that referenced this pull request Jul 29, 2016
@huangpf
Merge pull request Azure#581 from Azure/dev
e73a4af 
huangpf PR: dev <- Azure:dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepakRajendranMsft @azurecla @markcowl @deepakswifty