Skip to content

[#4181] Fix exception telemetry. #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cormacpayne merged 1 commit into from
Jun 23, 2017
Merged

[#4181] Fix exception telemetry. #4185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Common/Commands.Common/MetricHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ private void LogExceptionEvent(AzurePSQoSEvent qos)
LoadTelemetryClientContext(qos, client.Context);
PopulatePropertiesFromQos(qos, eventProperties);
// qos.Exception contains exception message which may contain Users specific data.
// We should not collect users specific data.
// We should not collect users specific data.
eventProperties.Add("Message", "Message removed due to PII.");
eventProperties.Add("StackTrace", qos.Exception.StackTrace);
eventProperties.Add("ExceptionType", qos.Exception.GetType().ToString());
client.TrackException(null, eventProperties, eventMetrics);
Expand Down