Skip to content

Conversation

@hovsepm
Copy link
Contributor

@hovsepm hovsepm commented Dec 13, 2016

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@hovsepm
Copy link
Contributor Author

hovsepm commented Dec 13, 2016

@hovsepm
Copy link
Contributor Author

hovsepm commented Dec 13, 2016

restarted sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/772/

Yaaay! this one passed :)))

@hovsepm
Copy link
Contributor Author

hovsepm commented Dec 13, 2016

@cormacpayne Your turn ;)

@cormacpayne
Copy link
Member

:shipit:

@cormacpayne cormacpayne merged commit 13571f0 into Azure:release-3.3.0 Dec 13, 2016
@hovsepm hovsepm deleted the release-3.3.0 branch June 13, 2017 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants