Adding platform fault domain and avzone support #28681

abageria · 2025-10-13T22:01:16Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-10-13T22:01:19Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

microsoft-github-policy-service · 2025-10-13T22:01:54Z

Thank you for your contribution @abageria! We will review the pull request and get back to you soon.

abageria · 2025-10-13T22:19:08Z

@microsoft-github-policy-service agree company="Microsoft"

abageria · 2025-10-13T22:19:53Z

/azp run

azure-pipelines · 2025-10-13T22:20:00Z

Commenter does not have sufficient privileges for PR 28681 in repo Azure/azure-powershell

isra-fel · 2025-10-13T22:53:11Z

Hi @abageria if you are an employer of Microsoft please join the "Azure" organization here: https://aka.ms/AzureGitHub

riyanshpal · 2025-10-16T16:36:45Z

...teRecovery/ReplicationProtectedItem/NewAzureRmRecoveryServicesAsrReplicationProtectedItem.cs

+        [Parameter(ParameterSetName = ASRParameterSets.AzureToAzure, HelpMessage = "Specify the platform fault domain to be used by the failover Vm in target recovery region.")]
+        [Parameter(ParameterSetName = ASRParameterSets.AzureToAzureWithoutDiskDetails, HelpMessage = "Specify the platform fault domain to be used by the failover Vm in target recovery region.")]
+        [ValidateNotNullOrEmpty]
+        public int? PlatformFaultDomain { get; set; }


Its data type is nullable int, but we are also validating that it can't be null. These two are contradicting each other.

riyanshpal · 2025-10-16T16:43:25Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

    #create virtual Machine scale set
    $stnd = "Standard"
-    $vmssConfig = New-AzVmssConfig -Location $recoveryLocation -PlatformFaultDomainCount 1 -SinglePlacementGroup 0 -SecurityType $stnd
+    $vmssConfig = New-AzVmssConfig -Location $recoveryLocation -PlatformFaultDomainCount 2 -SinglePlacementGroup 0 -SecurityType $stnd


get the value of platformFaultDomainCount from helper class like you are doing for platformFaultDomain.

riyanshpal · 2025-10-16T16:44:28Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

    #Validate vmss Set in replicated vm properties
    $pe = Get-AzRecoveryServicesAsrReplicationProtectedItem -ProtectionContainer $pc -Name  $vmName
    Assert-NotNull($pe.providerSpecificDetails.RecoveryVirtualMachineScaleSetId)
+    Assert-NotNull($pe.providerSpecificDetails.PlatformFaultDomain)


Also validate Equal

riyanshpal · 2025-10-16T16:44:46Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

    WaitForJobCompletion -JobId $updateDRjob.Name
    $pe = Get-AzRecoveryServicesAsrReplicationProtectedItem -ProtectionContainer $pc -Name  $vmName
    Assert-NotNull($pe.providerSpecificDetails.RecoveryVirtualMachineScaleSetId)
+    Assert-NotNull($pe.providerSpecificDetails.PlatformFaultDomain)


Same as above.

riyanshpal · 2025-10-16T16:45:18Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

 $rgId = "/subscriptions/7c943c1b-5122-4097-90c8-861411bdd574/resourceGroups/vijami-alertrg"

-$ReprotectJob = Update-AzRecoveryServicesAsrProtectionDirection -AzureToAzure -ReplicationProtectedItem $ReplicationProtectedItem -ProtectionContainerMapping $RecoveryMapping -LogStorageAccountId $CacheStorageAccount -RecoveryResourceGroupID $rgId
+$platformFaultDomain = 1


don't have constants here, get all these values from helper class.

riyanshpal · 2025-10-16T16:45:59Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

-$ReprotectJob = Update-AzRecoveryServicesAsrProtectionDirection -AzureToAzure -ReplicationProtectedItem $ReplicationProtectedItem -ProtectionContainerMapping $RecoveryMapping -LogStorageAccountId $CacheStorageAccount -RecoveryResourceGroupID $rgId
+$platformFaultDomain = 1
+
+$ReprotectJob = Update-AzRecoveryServicesAsrProtectionDirection -AzureToAzure -ReplicationProtectedItem $ReplicationProtectedItem -ProtectionContainerMapping $RecoveryMapping -LogStorageAccountId $CacheStorageAccount -RecoveryResourceGroupID $rgId -PlatformFaultDomain $platformFaultDomain


Get protected item and perform validations.

riyanshpal · 2025-10-16T16:46:26Z

...teRecovery/ReplicationProtectedItem/SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs

+        ///     Gets or sets the platform fault domain for replication protected item after failover.
+        /// </summary>
+        [Parameter]
+        [ValidateNotNullOrEmpty]


Same as above.

isra-fel

Please also add a new entry to ChangeLog.md

github-actions · 2025-10-20T01:59:52Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

isra-fel · 2025-10-27T13:54:09Z

/azp run

azure-pipelines · 2025-10-27T13:54:26Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull Request Overview

This PR adds support for Platform Fault Domain and Availability Zone parameters in Azure Site Recovery protection workflows. The changes include:

Adding PlatformFaultDomain and RecoveryAvailabilityZone parameters to cmdlets for Enable, Update, and Switch Protection operations
Updating the SDK to version 2025-08-01 API
Adding test coverage for the new parameters
Extending VMware CBT and InMageRcm scenarios with disk configuration properties (IOPS, throughput, disk size)

Reviewed Changes

Copilot reviewed 10 out of 50 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Update-AzRecoveryServicesAsrProtectionDirection.md	Added documentation for RecoveryAvailabilityZone and PlatformFaultDomain parameters
Set-AzRecoveryServicesAsrReplicationProtectedItem.md	Added documentation for PlatformFaultDomain parameter
New-AzRecoveryServicesAsrReplicationProtectedItem.md	Added documentation for PlatformFaultDomain parameter
UpdateAzureRmRecoveryServicesAsrProtectionDirection.cs	Added RecoveryAvailabilityZone and PlatformFaultDomain properties to cmdlet
SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs	Added PlatformFaultDomain property and validation logic
NewAzureRmRecoveryServicesAsrReplicationProtectedItem.cs	Added PlatformFaultDomain property with incorrect XML doc
AsrA2ATests.ps1	Added test coverage for new parameters with typo in variable name
A2ATestsHelper.ps1	Added helper functions with naming inconsistencies
README.md	Updated SDK commit hash and API version
SDK Generated files	Generated code from updated OpenAPI spec including new models and operations
ChangeLog.md	Added release notes entry

Copilot · 2025-10-30T18:54:02Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

    $recoveryNetMapping = getRecoveryNetworkMapping
+    $platformFaultDomain = getPlatformDomain
+    $platformFaultDomain1 = getPlatformDomain1
+    $platoformFaultDomainCount2 = getPlatformDomainCount2


Corrected spelling of 'platoformFaultDomainCount2' to 'platformFaultDomainCount2'.

Copilot · 2025-10-30T18:54:02Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

    $recoveryNetMapping = getRecoveryNetworkMapping
+    $platformFaultDomain = getPlatformDomain
+    $platformFaultDomain1 = getPlatformDomain1
+    $platoformFaultDomainCount2 = getPlatformDomainCount2


The function 'getPlatformDomainCount2' is being called but is not defined in A2ATestsHelper.ps1. Based on the helper file, the correct function name should be 'getPlatformUpdateDomain2' (though that function itself has a naming issue noted separately).

Copilot · 2025-10-30T18:54:03Z

src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1

+    $platformFaultDomain = getPlatformDomain
+    $platformFaultDomain1 = getPlatformDomain1


Functions 'getPlatformDomain' and 'getPlatformDomain1' are being called but are not defined in A2ATestsHelper.ps1. The correct function names based on the helper file are 'getPlatformFaultDomain' and 'getPlatformUpdateDomain1'.

Copilot · 2025-10-30T18:54:03Z

...teRecovery/ReplicationProtectedItem/NewAzureRmRecoveryServicesAsrReplicationProtectedItem.cs

        public ASRReplicationProtectionCluster ReplicationProtectionCluster { get; set; }

+        /// <summary>
+        /// Gets or sets the resource ID of virtual machine scale set to failover this virtual machine to.


The XML documentation comment is incorrect. This property is for PlatformFaultDomain, not for virtual machine scale set resource ID. The comment should describe the platform fault domain property instead.

Copilot · 2025-10-30T18:54:03Z

...teRecovery/ReplicationProtectedItem/SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs

+                            this.KeyEncryptionVaultId),
+                        PlatformFaultDomain = this.PlatformFaultDomain


The PlatformFaultDomain is assigned from 'this.PlatformFaultDomain' instead of the local variable 'platformFaultDomain' that was set earlier (lines 429, 705-707). This bypasses the logic that preserves the existing value when the parameter is not bound, making the fallback behavior ineffective.

isra-fel · 2025-10-30T19:08:56Z

/azp run

azure-pipelines · 2025-10-30T19:09:13Z

Azure Pipelines successfully started running 3 pipeline(s).

abageria added 2 commits October 12, 2025 18:13

generated private sdk

18da2aa

Adding platform fault domain and avzone support

5a4d2e7

microsoft-github-policy-service bot added the customer-reported label Oct 13, 2025

riyanshpal reviewed Oct 16, 2025

View reviewed changes

isra-fel requested changes Oct 20, 2025

View reviewed changes

isra-fel added needs-revision and removed customer-reported labels Oct 20, 2025

isra-fel assigned abageria Oct 20, 2025

isra-fel assigned dolauli Oct 28, 2025

Resolved comments

89149c1

Copilot AI review requested due to automatic review settings October 30, 2025 18:43

Merge branch 'main' into origin/abageria/VmssFlexPowershellChanges

df625c8

Copilot AI reviewed Oct 30, 2025

View reviewed changes

		$platformFaultDomain = getPlatformDomain
		$platformFaultDomain1 = getPlatformDomain1

		this.KeyEncryptionVaultId),
		PlatformFaultDomain = this.PlatformFaultDomain

Adding platform fault domain and avzone support #28681

Are you sure you want to change the base?

Adding platform fault domain and avzone support #28681

Uh oh!

Conversation

abageria commented Oct 13, 2025

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Oct 13, 2025

Uh oh!

microsoft-github-policy-service bot commented Oct 13, 2025

Uh oh!

abageria commented Oct 13, 2025

Uh oh!

abageria commented Oct 13, 2025

Uh oh!

azure-pipelines bot commented Oct 13, 2025

Uh oh!

isra-fel commented Oct 13, 2025

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

riyanshpal Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

isra-fel commented Oct 27, 2025

Uh oh!

azure-pipelines bot commented Oct 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

isra-fel commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone