Skip to content

Conversation

@VeryEarly
Copy link
Collaborator

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@VeryEarly VeryEarly self-assigned this Jul 31, 2024
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 31, 2024

⚠️Az.HdInsightOnAks
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Invoke-AzHdInsightOnAksClusterPoolUpgrade 2 4 Mismatched_Parameter_Value_Type Invoke-AzHdInsightOnAksClusterPoolUpgrade -ClusterPoolUpgradeRequest $upgradeObj is not an expected parameter value type. -ClusterPoolUpgradeRequest Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.HdInsightOnAks.Models.IClusterPoolUpgrade. Now the type is Microsoft.Azure.PowerShell.Cmdlets.HdInsightOnAks.Models.ClusterPoolAksPatchVersionUpgradeProperties.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Invoke-AzHdInsightOnAksClusterPoolUpgrade 2 4 Mismatched_Parameter_Value_Type Invoke-AzHdInsightOnAksClusterPoolUpgrade -ClusterPoolUpgradeRequest $upgradeObj is not an expected parameter value type. -ClusterPoolUpgradeRequest Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.HdInsightOnAks.Models.IClusterPoolUpgrade. Now the type is Microsoft.Azure.PowerShell.Cmdlets.HdInsightOnAks.Models.ClusterPoolAksPatchVersionUpgradeProperties.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeryEarly VeryEarly merged commit 040533d into release-2024-08-06 Jul 31, 2024
@VeryEarly VeryEarly deleted the yabo/remove-progressaction branch July 31, 2024 05:37
VeryEarly added a commit that referenced this pull request Aug 1, 2024
* remove common parameter ProgressAction (#25689)

* Migrate HdInsightOnAks from generation to release-2024-08-06 (#25707)

* Move HdInsightOnAks to release-2024-08-06

* Update ChangeLog.md

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>

* remove common parameter ProgressAction (#25708)

* bump version to Az 12.2.0 (#25719)

---------

Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com>
Co-authored-by: azure-powershell-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants