Migrate KeyVault from generation to release-2024-04-02 #24525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.CosmosDB
️✔️Az.EventHub
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzKeyVaultManagedHsmRegion | Get-AzKeyVaultManagedHsmRegion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzKeyVaultManagedHsmRegion | Get-AzKeyVaultManagedHsmRegion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzKeyVaultManagedHsmRegion | Get-AzKeyVaultManagedHsmRegion Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzKeyVaultManagedHsmRegion | Get-AzKeyVaultManagedHsmRegion changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Add-AzKeyVaultKey 8 1 Unassigned_Variable Add-AzKeyVaultKey -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Add-AzKeyVaultKey 8 1 Unassigned_Variable Add-AzKeyVaultKey -Name $keyName is a null-valued parameter value. -Name Assign value for $keyName. ⚠️ Add-AzKeyVaultKey 10 1 Unassigned_Variable New-AzKeyVault -Name $keyVaultName is a null-valued parameter value. -Name Assign value for $keyVaultName. ⚠️ Add-AzKeyVaultKey 10 1 Unassigned_Variable New-AzKeyVault -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ Add-AzKeyVaultKey 10 1 Unassigned_Variable New-AzKeyVault -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Add-AzKeyVaultKey 10 3 Unassigned_Variable Set-AzKeyVaultAccessPolicy -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Add-AzKeyVaultKey 10 3 Unassigned_Variable Set-AzKeyVaultAccessPolicy -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Add-AzKeyVaultKey 10 6 Unassigned_Variable Add-AzKeyVaultKey -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Add-AzKeyVaultKey 10 6 Unassigned_Variable Add-AzKeyVaultKey -Name $keyName is a null-valued parameter value. -Name Assign value for $keyName. ⚠️ Add-AzKeyVaultManagedStorageAccount 1 5 Unassigned_Variable Set-AzKeyVaultAccessPolicy -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Get-AzKeyVaultCertificate 2 1 Unassigned_Variable Get-AzKeyVaultSecret -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Get-AzKeyVaultCertificate 2 1 Unassigned_Variable Get-AzKeyVaultSecret -Name $certName is a null-valued parameter value. -Name Assign value for $certName. ⚠️ Get-AzKeyVaultKey 8 2 Unassigned_Variable Get-AzKeyVaultKey -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Get-AzKeyVaultKey 8 2 Unassigned_Variable Get-AzKeyVaultKey -KeyName $keyName is a null-valued parameter value. -KeyName Assign value for $keyName. ⚠️ Import-AzKeyVaultSecurityDomain 2 5 Unassigned_Variable Import-AzKeyVaultSecurityDomain -ExchangeKeyPath $exchangeKeyPath is a null-valued parameter value. -ExchangeKeyPath Assign value for $exchangeKeyPath. ⚠️ Invoke-AzKeyVaultKeyOperation 2 1 Unassigned_Variable Invoke-AzKeyVaultKeyOperation -ByteArrayValue $encryptedData.RawResult is a null-valued parameter value. -ByteArrayValue Assign value for $encryptedData.RawResult. ⚠️ Invoke-AzKeyVaultKeyOperation 4 1 Unassigned_Variable Invoke-AzKeyVaultKeyOperation -ByteArrayValue $encryptedData.RawResult is a null-valued parameter value. -ByteArrayValue Assign value for $encryptedData.RawResult. ⚠️ Invoke-AzKeyVaultKeyOperation 6 1 Unassigned_Variable ConvertTo-SecureString -String $result.Result is a null-valued parameter value. -String Assign value for $result.Result. ⚠️ Update-AzKeyVault 1 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVault 1 1 Unassigned_Variable Get-AzKeyVault -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVault 2 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVault 2 1 Unassigned_Variable Get-AzKeyVault -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVault 3 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVault 4 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVaultManagedHsm 1 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -Name $hsmName is a null-valued parameter value. -Name Assign value for $hsmName. ⚠️ Update-AzKeyVaultManagedHsm 1 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVaultManagedHsm 2 1 Unassigned_Variable Get-AzKeyVaultManagedHsm -Name $hsmName is a null-valued parameter value. -Name Assign value for $hsmName. ⚠️ Update-AzKeyVaultManagedHsm 2 1 Unassigned_Variable Get-AzKeyVaultManagedHsm -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVaultManagedHsm 3 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -Name $hsmName is a null-valued parameter value. -Name Assign value for $hsmName. ⚠️ Update-AzKeyVaultManagedHsm 3 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Add-AzKeyVaultKey 8 1 Unassigned_Variable Add-AzKeyVaultKey -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Add-AzKeyVaultKey 8 1 Unassigned_Variable Add-AzKeyVaultKey -Name $keyName is a null-valued parameter value. -Name Assign value for $keyName. ⚠️ Add-AzKeyVaultKey 10 1 Unassigned_Variable New-AzKeyVault -Name $keyVaultName is a null-valued parameter value. -Name Assign value for $keyVaultName. ⚠️ Add-AzKeyVaultKey 10 1 Unassigned_Variable New-AzKeyVault -Location $location is a null-valued parameter value. -Location Assign value for $location. ⚠️ Add-AzKeyVaultKey 10 1 Unassigned_Variable New-AzKeyVault -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Add-AzKeyVaultKey 10 3 Unassigned_Variable Set-AzKeyVaultAccessPolicy -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Add-AzKeyVaultKey 10 3 Unassigned_Variable Set-AzKeyVaultAccessPolicy -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Add-AzKeyVaultKey 10 6 Unassigned_Variable Add-AzKeyVaultKey -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Add-AzKeyVaultKey 10 6 Unassigned_Variable Add-AzKeyVaultKey -Name $keyName is a null-valued parameter value. -Name Assign value for $keyName. ⚠️ Add-AzKeyVaultManagedStorageAccount 1 5 Unassigned_Variable Set-AzKeyVaultAccessPolicy -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Get-AzKeyVaultCertificate 2 1 Unassigned_Variable Get-AzKeyVaultSecret -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Get-AzKeyVaultCertificate 2 1 Unassigned_Variable Get-AzKeyVaultSecret -Name $certName is a null-valued parameter value. -Name Assign value for $certName. ⚠️ Get-AzKeyVaultKey 8 2 Unassigned_Variable Get-AzKeyVaultKey -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Get-AzKeyVaultKey 8 2 Unassigned_Variable Get-AzKeyVaultKey -KeyName $keyName is a null-valued parameter value. -KeyName Assign value for $keyName. ⚠️ Import-AzKeyVaultSecurityDomain 2 5 Unassigned_Variable Import-AzKeyVaultSecurityDomain -ExchangeKeyPath $exchangeKeyPath is a null-valued parameter value. -ExchangeKeyPath Assign value for $exchangeKeyPath. ⚠️ Invoke-AzKeyVaultKeyOperation 2 1 Unassigned_Variable Invoke-AzKeyVaultKeyOperation -ByteArrayValue $encryptedData.RawResult is a null-valued parameter value. -ByteArrayValue Assign value for $encryptedData.RawResult. ⚠️ Invoke-AzKeyVaultKeyOperation 4 1 Unassigned_Variable Invoke-AzKeyVaultKeyOperation -ByteArrayValue $encryptedData.RawResult is a null-valued parameter value. -ByteArrayValue Assign value for $encryptedData.RawResult. ⚠️ Invoke-AzKeyVaultKeyOperation 6 1 Unassigned_Variable ConvertTo-SecureString -String $result.Result is a null-valued parameter value. -String Assign value for $result.Result. ⚠️ Update-AzKeyVault 1 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVault 1 1 Unassigned_Variable Get-AzKeyVault -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVault 2 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVault 2 1 Unassigned_Variable Get-AzKeyVault -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVault 3 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVault 4 1 Unassigned_Variable Get-AzKeyVault -VaultName $keyVaultName is a null-valued parameter value. -VaultName Assign value for $keyVaultName. ⚠️ Update-AzKeyVaultManagedHsm 1 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -Name $hsmName is a null-valued parameter value. -Name Assign value for $hsmName. ⚠️ Update-AzKeyVaultManagedHsm 1 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVaultManagedHsm 2 1 Unassigned_Variable Get-AzKeyVaultManagedHsm -Name $hsmName is a null-valued parameter value. -Name Assign value for $hsmName. ⚠️ Update-AzKeyVaultManagedHsm 2 1 Unassigned_Variable Get-AzKeyVaultManagedHsm -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzKeyVaultManagedHsm 3 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -Name $hsmName is a null-valued parameter value. -Name Assign value for $hsmName. ⚠️ Update-AzKeyVaultManagedHsm 3 1 Unassigned_Variable Update-AzKeyVaultManagedHsm -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.KeyVault. Add a changelog record under Upcoming Release section with past tense.
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.KeyVault. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 22.09 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 22.09% Test coverage for the module cannot be lower than 50%.
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
vidai-msft
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate KeyVault from generation to release-2024-04-02
The last commit of src/KeyVault in generation is:
commit a306136 Author: Vincent Dai [email protected] Date: Mon Mar 25 08:41:17 2024 -0700 Mitigate MI breaking changes (#24483) * Mitigate MI breaking changes * Update README.md * Update README.md
Checklist