New-AzVM bug: when image id is provided, fails to find version #23897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
|
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 78.58 % | 84.35% | Test coverage cannot be lower than the number of the last release. |
⚠️ - MacOS
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 78.58% | 84.35% | Test coverage cannot be lower than the number of the last release. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 78.58% | 84.35% | Test coverage cannot be lower than the number of the last release. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 78.58% | 84.35% | Test coverage cannot be lower than the number of the last release. |
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
Sandido
requested review from
bilaakpan-ms and
grizzlytheodore
as code owners
wyunchi-ms
previously approved these changes
Jan 29, 2024
Contributor
|
LGTM |
wyunchi-ms
approved these changes
Jan 29, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in New-AzVM. New-AzVM by default looks at the Image Id provided to get the image based on the provided publisher, offer, sku, and version that is assumed in the id.
Apparently there are other scenarios of different Ids that can be provided. This PR edits the code to provide a message in the Gallery Image Id and Managed Image Id scenarios as requested in this design request: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1243
This will prevent an error message where the Version cannot be found when certain Id formats are provided.
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.