Recovery Services Backup Initial PR

[dragonfly91]

Hi,

This PR comprises of a draft version of the new module - RecoveryServices.Backup. We wanted to get an early feedback on various aspects of the code / design etc. Please review the PR but do NOT merge the PR - since this changeset contains only a few cmdlets. Look forward to your feedback.

Thanks,
Anudeep.

[hovsepm]

@dragonfly91 What is relationship between changes in AzureBackup and RecoveryServices and adding RecoveryServices.Backup module to the repository? could they go in independent of each other?

[hovsepm]

@dragonfly91 please change the overall folder structure. Take a look to src\ResourceManager\RecoveryServices project -> product and Test should be in a different folders.

[hovsepm]

Your cmdlets should not define 2 output types for lists and for single types.

OutputType(typeof(List<AzureRmRecoveryServicesContainerBase>), typeof(AzureRmRecoveryServicesContainerBase))

do not define List, instead when you do write object specify that it can be an enumerable collection. e.g.

WriteObject(containerModels, enumerateCollection: true);

[hovsepm]

@dragonfly91 you should NOT use things like

Thread.Sleep(15 * 1000); 

things (e.g. StopAzureRmRecoveryServicesJob.cs file).
Use TestMockSupport.Delay method from Commands.Common project.

[hovsepm]

Move Commands.RecoveryServices.Backup.Helpers and other projects to separate folders under RecoveryServices.Backup folder. Do not put projects in nested subfolders.

[hovsepm]

Why do you have so many library packages that are only referenced in one module?

[hovsepm]

you should not reference anything from GAC (e.g. Commands.RecoveryServices.Backup.Cmdlets.csproj)

    <Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
      <SpecificVersion>False</SpecificVersion>
      <HintPath>C:\Windows\Microsoft.NET\assembly\GAC_MSIL\System.Management.Automation\v4.0_3.0.0.0__31bf3856ad364e35\System.Management.Automation.dll</HintPath>
    </Reference>

remove the hint path.

[hovsepm]

@dragonfly91 since you guys added your module to AzureRM and also added psd1 file for RecoveryServices.Backup you will need to regenerate wxi file and include it to this PR as well.

[hovsepm]

on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/716/

[hovsepm]

sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/385/

[hovsepm]

new sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/388/

[hovsepm]

another one for sing job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/390/

[hovsepm]

sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/391/

[hovsepm]

on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/720/

[hovsepm]

revert this line

[hovsepm]

on-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/722/
sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/394/

[markcowl]

signing: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/398/