Updating the Azure US Gov Cloud STS and Traffic Manager #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the STS URL for Azure Gov to the US Only STS that was stood up for Azure Gov. Adding the Traffic Manager Suffix Updating the Add-AzureAccount and Add-AzureRMAccount documentation to include AzureUSGovernment in the text and to change Environment to EnvironmentName to be easier to use.
|
Hi @zakramer, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
Can one of the admins verify this patch? |
Contributor
|
@azuresdkci add to whitelist |
Contributor
|
re-targeted to release branch in #2072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the STS URL for Azure Gov to the US Only STS that was stood up
for Azure Gov. - The AAD team has stood up an STS endpoint (login-us.microsoftonline.com) that will limit traffic to US Only servers. This is the STS that the Azure US Government portal (https://manage.windowsazure.us) is now using. To ensure that all Azure US Government customers are using the US Only servers (to ensure compliance) we want to update the Environment for Azure US Government to use this STS.
Adding the Traffic Manager Suffix - Noticed that this was missing so I added it. I can remove and make a separate PR is that is better.
Updating the Add-AzureAccount and Add-AzureRMAccount documentation to include AzureUSGovernment in the text and to change Environment to EnvironmentName to be easier to use. Noticed that the documentation was very confusing during testing so I updated some of the docs to include AzureUSGovernment as an option.
Also, I noticed that everyone uses EnvironmentName for Add-AzureRMAccount but that was not in the docs. Just updated Environment to EnvironmentName. I can add both if that makes more sense but it seemed that having less is better since EnvironmentName is the one that is easy to use.