Skip to content

Conversation

@isra-fel
Copy link
Member

Description

Fix a minor error in Az.Marketplace.psd1. No changelog or new release required.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@isra-fel isra-fel marked this pull request as ready for review July 20, 2022 05:45
@BethanyZhou
Copy link
Contributor

BethanyZhou commented Jul 20, 2022

Awesome! How did you identify this error?

@isra-fel
Copy link
Member Author

I wrote a script to generate a cmdlet/alias to module mapping, and there was one line in the result that's unlike anything else, so I checked the psd1 file and found the issue ;)

@isra-fel isra-fel merged commit 00e1375 into main Jul 20, 2022
@isra-fel isra-fel deleted the isra-fel-patch-1 branch July 20, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants