Skip to content

Changes for validations for new ssl policies for Application Gateway #18287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 2 commits into from
Jun 16, 2022
Merged

Changes for validations for new ssl policies for Application Gateway #18287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832d0b0
powershell changes for new ssl policies in appgw
kaushik-ms May 25, 2022
f80ccfc
Merge branch 'main' of https://github.com/Azure/azure-powershell into…
kaushik-ms Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Network/Network/ApplicationGateway/SslPolicy/AzureApplicationGatewaySslPolicyBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ public class AzureApplicationGatewaySslPolicyBase : NetworkBaseCmdlet
{
[Parameter(
HelpMessage = "List of SSL protocols to be disabled")]
[ValidateSet("TLSv1_0", "TLSv1_1", "TLSv1_2", IgnoreCase = true)]
[ValidateSet("TLSv1_0", "TLSv1_1", "TLSv1_2", "TLSv1_3", IgnoreCase = true)]
[ValidateNotNullOrEmpty]
public string[] DisabledSslProtocols { get; set; }

[Parameter(
HelpMessage = "Type of Ssl Policy")]
[ValidateSet("Predefined", "Custom", IgnoreCase = true)]
[ValidateSet("Predefined", "Custom", "CustomV2", IgnoreCase = true)]
public string PolicyType { get; set; }

[Parameter(
Expand All @@ -38,12 +38,11 @@ public class AzureApplicationGatewaySslPolicyBase : NetworkBaseCmdlet

[Parameter(
HelpMessage = "Ssl cipher suites to be enabled in the specified order to application gateway")]
[ValidateNotNullOrEmpty]
public string[] CipherSuite { get; set; }

[Parameter(
HelpMessage = "Minimum version of Ssl protocol to be supported on application gateway")]
[ValidateSet("TLSv1_0", "TLSv1_1", "TLSv1_2", IgnoreCase = true)]
[ValidateSet("TLSv1_0", "TLSv1_1", "TLSv1_2", "TLSv1_3", IgnoreCase = true)]
public string MinProtocolVersion { get; set; }

public override void ExecuteCmdlet()
Expand Down
4 changes: 4 additions & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
--->

## Upcoming Release
* Added support for CustomV2 ssl policies for Application Gateway.
- Added `CustomV2` to the validation set of `PolicyType`
- Added `TLSv1_3` to the validation set of `MinProtocolVersion`
- Removed validation for null or empty cipher suites list since there can be empty cipher suites list for min protocol version of tls1.3

## Version 4.17.0
* Supported `Microsoft.Network/privateLinkServices` in `Get-AzPrivateEndpointConnection` [#16984].
Expand Down