Skip to content

Conversation

@NaveenGoli
Copy link
Contributor

No description provided.

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @NaveenGoli, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (ngoli). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this project?

@amitapl
Copy link

amitapl commented Feb 10, 2015

Is the file src/ResourceManager/Websites/Commands.Websites/MSSharedLibKey.snk required in the repo?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra new lines

@ogail
Copy link
Contributor

ogail commented Feb 10, 2015

@azuresdkci add to whitelist

@NaveenGoli
Copy link
Contributor Author

I have incorporated all the feedback changes. please review..

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have some extra \n throughout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@amitapl
Copy link

amitapl commented Feb 12, 2015

looks good

@NaveenGoli
Copy link
Contributor Author

Will this be merged? AFAI can see, Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests has no relation to websites code changes.. please let me know what the next steps are..

@matt-gibbs
Copy link

Not until the tests are passing. The reason New-AzureResourceGroup is not being found will need to be investigated.

@matt-gibbs
Copy link

re-test this please.

@NaveenGoli
Copy link
Contributor Author

its passing on my local machine..

Assemblies Run

C:\GitHUb\azure-powershell\src\ResourceManager\Sql\Commands.Sql.Test\bin\Debug\Microsoft.Azure.Commands.Sql.Test.dll

Summary

Tests run: 3 Skipped: 2, Run time: 57.330s

Skipped tests

Skipped

Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests.TestDatabaseUpdatePolicyWithStorage

Skipped

Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests.TestFailedDatabaseUpdatePolicyWithNoStorage

All tests

Click test class name to expand/collapse test details

57.070s

Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests (3 tests)

@NaveenGoli
Copy link
Contributor Author

when will this pull be taken in? I was under the impression it will happen today?

stankovski added a commit that referenced this pull request Feb 25, 2015
Initial commit for the Websites commandlets for ARM
@stankovski stankovski merged commit df9a0ce into Azure:dev Feb 25, 2015
@yadavbdev
Copy link
Contributor

There is one issue with this merge, the project does not build now as it is using the deprecated property of AzurePSCmdlet 'CurrentContext', where it should have been Profile.Context?

@NaveenGoli
Copy link
Contributor Author

+Mark

Sent from my Windows Phone


From: Yadav Bhattarai (Microsoft)mailto:[email protected]
Sent: ‎2/‎25/‎2015 3:42 PM
To: Azure/azure-powershellmailto:[email protected]
Cc: Naveen Golimailto:[email protected]
Subject: Re: [azure-powershell] Initial commit for the Websites commandlets for ARM (#154)

There is one issue with this merge, the project does not build now as it is using the deprecated property of AzurePSCmdlet 'CurrentContext', where it should have been Profile.Context?


Reply to this email directly or view it on GitHub:
#154 (comment)

markcowl pushed a commit that referenced this pull request Sep 25, 2015
AzureRT referenced this pull request in AzureRT/azure-powershell Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants