Skip to content

Fix PartnerServerName check in GetAzureSqlDatabaseReplicationLink.cs #13433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Fix PartnerServerName check in GetAzureSqlDatabaseReplicationLink.cs #13433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f90acc
Fix PartnerServerName check
alecbain Nov 6, 2020
75bd0ca
Update ChangeLog.md
alecbain Nov 6, 2020
3f95a21
Use nameof to avoid magic string
alecbain Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Sql/Sql/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
## Upcoming Release
* Fixed issues where Set-AzSqlDatabaseAudit were not support Hyperscale database and database edition cannot be determined
* Added MaintenanceConfigurationId to 'New-AzSqlInstance' and 'Set-AzSqlInstance'
* Fixed a bug in GetAzureSqlDatabaseReplicationLink.cs where PartnerServerName parameter was being checked for by value instead of key

## Version 2.11.1
* Fixed issue where New-AzSqlDatabaseExport fails if networkIsolation not specified [#13097]
Expand Down
2 changes: 1 addition & 1 deletion src/Sql/Sql/Replication/Cmdlet/GetAzureSqlDatabaseReplicationLink.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ protected override IEnumerable<AzureReplicationLinkModel> GetEntity()
{
ICollection<AzureReplicationLinkModel> results;

if (MyInvocation.BoundParameters.ContainsKey(PartnerServerName) && !WildcardPattern.ContainsWildcardCharacters(PartnerServerName))
if (MyInvocation.BoundParameters.ContainsKey(nameof(PartnerServerName)) && !WildcardPattern.ContainsWildcardCharacters(PartnerServerName))
{
results = new List<AzureReplicationLinkModel>();
results.Add(ModelAdapter.GetLink(this.ResourceGroupName, this.ServerName, this.DatabaseName, this.PartnerResourceGroupName, this.PartnerServerName));
Expand Down