Skip to content

Conversation

@audunn
Copy link
Member

@audunn audunn commented Nov 1, 2020

Description

Adds new cmdLets for Snapshot policy, backuppolicy, backups, vaults, pool change. Model updates to bring up to api version 2020-06-01.
Removes Service level from Update-AzNetAppFilesPool as that is not allowed refer to pool change instead.

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/770

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Nov 2, 2020
@audunn
Copy link
Member Author

audunn commented Nov 8, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Nov 8, 2020

not sure why test windows fails. Allt test relating to this module are successful.

2020-11-08T21:56:22.6221568Z   Test run for D:\a\1\s\src\NetAppFiles\NetAppFiles.Test\bin\Debug\netcoreapp2.1\Microsoft.Azure.PowerShell.Cmdlets.NetAppFiles.Test.dll(.NETCoreApp,Version=v2.1)
2020-11-08T21:56:22.7870838Z   Microsoft (R) Test Execution Command Line Tool Version 16.7.0
2020-11-08T21:56:22.7872295Z   Copyright (c) Microsoft Corporation.  All rights reserved.
2020-11-08T21:56:22.7873552Z   
2020-11-08T21:56:22.9340230Z   Starting test execution, please wait...
2020-11-08T21:56:23.0399868Z   
2020-11-08T21:56:23.0405504Z   A total of 1 test files matched the specified pattern.
2020-11-08T21:59:20.4420020Z   Results File: D:\a\1\s\artifacts\TestResults\VssAdministrator_WIN-CB3SCTO3KGE_2020-11-08_21_56_31.trx
2020-11-08T21:59:20.4421791Z   
2020-11-08T21:59:20.4437830Z   Test Run Successful.
2020-11-08T21:59:20.4441041Z   Total tests: 22
2020-11-08T21:59:20.4442424Z        Passed: 22
2020-11-08T21:59:20.4443134Z    Total time: 2.9564 Minutes

@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

-->
## Upcoming Release

## Version 0.1.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add or update any versions in changelog because they are calculated according to sementic versioning at release time. Simply remove this line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually let me remove this for you as it seems to be the only issue blocking merging

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@isra-fel isra-fel added this to the S178 (2020-11-17) milestone Nov 9, 2020
@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Nov 9, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 68cdc03 into Azure:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants