Skip to content

Conversation

@Grayer123
Copy link
Contributor

@Grayer123 Grayer123 commented Feb 19, 2020

Description

Added 4 new cmdlets for tags:
- Gets the entire set of tags on a resource or subscription.
- Creates or updates the entire set of tags on a resource or subscription.
- Selectively updates the set of tags on a resource or subscription.
- Deletes the entire set of tags on a resource or subscription.

Design Review pr

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

isra-fel commented Feb 20, 2020

Hi @Grayer123 please don't assign new issues to someone. The scrum master of our team is responsible for it. :)

@isra-fel isra-fel removed their assignment Feb 20, 2020
hamidtirmizi
hamidtirmizi previously approved these changes Feb 23, 2020
@isra-fel isra-fel self-assigned this Feb 25, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Grayer123 please see my inline comments. Thanks

@Grayer123 Grayer123 assigned isra-fel and unassigned isra-fel and Grayer123 Feb 26, 2020
hamidtirmizi
hamidtirmizi previously approved these changes Feb 26, 2020
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit d0dca3d into Azure:master Feb 27, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Cmdlet changes for 2019-10-01 Tags API for resources and subscriptions
@Grayer123 Grayer123 deleted the feature/tagApi-2019-10-01 branch August 2, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants