Skip to content

Conversation

@ps-gregg
Copy link
Contributor

@ps-gregg ps-gregg commented Feb 8, 2020

Description

The three examples for Update-AzSqlServerVulnerabilityAssessmentSetting showed EmailSubscriptionAdmins as the parameter and output property which is incorrect. The parameter name is EmailAdmins and the property returned in the output is EmailAdmins.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

The three examples showed EmailSubscriptionAdmins as the parameter and output property which is incorrect.  The parameter name is EmailAdmins and the property returned in the output is EmailAdmins.
@VeryEarly
Copy link
Collaborator

please add one entry in src/Sql/Sql/ChangeLog.md to specify your change

@msftclas
Copy link

msftclas commented Feb 8, 2020

CLA assistant check
All CLA requirements met.

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 0c8bcf5 into Azure:master Feb 10, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Correct Example Parameter and Output Property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants