Set null if parameter AvailableToOtherTenants is not set #11024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
requested changes
Feb 5, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
The change looks good to me. Please add a change log entry, thanks
erich-wang
reviewed
Feb 5, 2020
| IdentifierUris = IdentifierUri, | ||
| ReplyUrls = ReplyUrl, | ||
| AvailableToOtherTenants = AvailableToOtherTenants | ||
| AvailableToOtherTenants = MyInvocation.BoundParameters.ContainsKey("AvailableToOtherTenants") ? AvailableToOtherTenants : (bool?)null |
Member
There was a problem hiding this comment.
Suggest to use IsParamaterBound to determine whether parameter is provided, just as line 90:
AvailableToOtherTenants = this.IsParameterBound(c => c.AvailableToOtherTenants ) ? AvailableToOtherTenants : (bool?)null;
erich-wang
previously requested changes
Feb 5, 2020
isra-fel
approved these changes
Feb 5, 2020
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
Set null if parameter AvailableToOtherTenants is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #10965
If AvailableToOtherTenants is not set, set null for update operation