Skip to content

Conversation

@MehaKaushik
Copy link
Contributor

@MehaKaushik MehaKaushik commented Jan 22, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jan 22, 2020
@MehaKaushik
Copy link
Contributor Author

Hey, @VeryEarly are you reviewing this PR ??

@VeryEarly
Copy link
Collaborator

VeryEarly commented Feb 3, 2020

Changelog.md need to be updated.

Please also resolve conflicts in Az.CosmosDB.psd1

@MehaKaushik
Copy link
Contributor Author

@VeryEarly
-> Reverted the breaking changes to include them in a subsequent PR.
-> Updated ChangeLog.md
-> Resolved Conflicts

@VeryEarly
Copy link
Collaborator

Hi @MehaKaushik ,

output type of New-AzCosmosDBSqlConflictResolutionPolicy was changed from "PSSqlConflictResolutionPolicy" to "PSConflictResolutionPolicy" which could be a breaking change. Can you add "PSSqlConflictResolutionPolicy.cs" back?

The help file New-AzCosmosDBSqlConflictResolutionPolicy.md should be also added back.

@MehaKaushik
Copy link
Contributor Author

@VeryEarly Changed as suggested for New-AzCosmosDBSqlConflictResolutionPolicy as well as for New-AzCosmosDBSqlUniqueKey, New-AzCosmosDBSqlUniqueKeyPolicy and New-AzCosmosDBSqlndexingPolicy.

@VeryEarly VeryEarly merged commit 68a75f2 into Azure:master Feb 6, 2020
@MehaKaushik MehaKaushik added this to the S166 (2020-03-10) milestone Feb 18, 2020
@MehaKaushik
Copy link
Contributor Author

@VeryEarly What needs to be done to make this PR into the next release ??

dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
CosmosDB Cassandra, Mongo, Table, Gremlin API with Management sdk 1.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants