Skip to content

Conversation

@ogail
Copy link
Contributor

@ogail ogail commented Oct 3, 2015

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianghaolu this can be improved when we change the AddHandler to override existing handler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as it would assure that the handler is refreshed.

@markcowl
Copy link
Member

markcowl commented Oct 5, 2015

@ogail new authentication package is published

@markcowl
Copy link
Member

markcowl commented Oct 6, 2015

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in a message here so the timeout shows up in the exception-catching trace below (or add a specific trace for the timeout)

@markcowl
Copy link
Member

markcowl commented Oct 6, 2015

@ogail the two recommended fixes are minimal, so the on-demand doesn't need to be re-run if you fix these.

@ogail
Copy link
Contributor Author

ogail commented Oct 6, 2015

@ogail
Copy link
Contributor Author

ogail commented Oct 6, 2015

ogail added a commit that referenced this pull request Oct 6, 2015
Support automatic RP registration
@ogail ogail merged commit 5c9d426 into Azure:dev Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants