-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Closed
Labels
EngineeringP2feature-requestThis issue requires a new behavior in the product in order be resolved.This issue requires a new behavior in the product in order be resolved.
Milestone
Description
Description
During the process of bumping version, the script will validate existing modules whether indeed need to updated.
Its current logic judges based on checking the required version url of module if exists.
For example, https://www.powershellgallery.com/packages/Az.Accounts/2.1.4 should not exist because the current Az.Accounts version is 2.1.2.
But seems PSGallery changes its behaviour, the url of required module will be redirected to the latest version url of module.
So the httpstatus will always be ok.
azure-powershell/tools/VersionController/Models/VersionValidator.cs
Lines 143 to 154 in c8b437e
| private bool DoesUrlExists(string url) | |
| { | |
| HttpWebRequest request = (HttpWebRequest)WebRequest.Create(url); | |
| request.Method = WebRequestMethods.Http.Head; | |
| try | |
| { | |
| using (HttpWebResponse response = (HttpWebResponse)request.GetResponse()) | |
| { | |
| if (response.StatusCode == HttpStatusCode.OK) | |
| { | |
| return true; | |
| } |
Maybe we need update the verification logic or skip this step for efficiency.
Cost
Metadata
Metadata
Assignees
Labels
EngineeringP2feature-requestThis issue requires a new behavior in the product in order be resolved.This issue requires a new behavior in the product in order be resolved.