Fix concurrency issue of Component Registery of Azure Session #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the test cases for component registeration
msJinLei
force-pushed
the
jinlei/componentRegistry
branch
from
2b81798 to
10ae7e0
Compare
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a concurrency issue in the component registration for AzureSession, ensuring that component initialization and event handler updates occur atomically during concurrent operations.
- Refactored component registration logic to use AddOrUpdate to improve thread-safety.
- Updated event handler registration and unregistration for handling listener components.
- Added extensive tests to validate different component registration and unregistration scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Authentication.Abstractions/AzureSession.cs | Updated RegisterComponent method to atomically update components and correctly manage event subscriptions under concurrency |
| src/Authentication.Abstractions.Test/AzureSessionTest.cs | Added tests covering parallel registration, unregistration, and event handler invocation scenarios |
msJinLei
changed the title
NoriZC
reviewed
Apr 1, 2025
NoriZC
reviewed
Apr 1, 2025
isra-fel
previously approved these changes
Apr 1, 2025
NoriZC
reviewed
Apr 1, 2025
NoriZC
approved these changes
Apr 1, 2025
isra-fel
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to fix
RegisterComponent, the operation that checks key existance_componentRegistry.TryGetValue(key, out var existed)and the operation that updates the value of the key_componentRegistry[key] = componentare not atomic. The result is the when you want to register the components with the same key in different threads in no-overwrite mode, the component is actually overwritten. What you can see is that with the unfixed codes, the result of the test caseTestComponentRegistrationSameComponentNoOverwrittenis unpredictable.