Change the default warning message of CmdletPreviewAttribute and allow setting ETA #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyZhou
force-pushed
the
bez/cmdletpreview
branch
from
d7ac7f6 to
3d75c4a
Compare
BethanyZhou
force-pushed
the
bez/cmdletpreview
branch
from
d018d66 to
0adc6a0
Compare
isra-fel
reviewed
Jul 20, 2023
| this._message = string.IsNullOrEmpty(message) ? Resources.PreviewCmdletMessage : message; | ||
| } | ||
|
|
||
| public CmdletPreviewAttribute(string message, string estimatedDateOfGa) : this(message) |
Member
There was a problem hiding this comment.
How do we avoid confusion for dates like "1/2/2023"? Some may interpret it as Jan 2nd, some Feb 1st.
Contributor
Author
There was a problem hiding this comment.
The date assume the date follows "en-US" culture like breaking change attribute, which means dates are written in the month–day–year order.
Contributor
Author
There was a problem hiding this comment.
The benefits of using local culture to display estimated GA date is customer are more familiar with their local date. But considering:
- to keep consistent with breaking change attribute, CmdletPreviewAttribute won't display estimatedGaDate with local culture to avoid introduce new confusion.
- Customer may use the output as the input of DateTime, standard date time will avoid parse issue.
isra-fel
approved these changes
Jul 20, 2023
wyunchi-ms
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.