Skip to content

Add a default script_file to support function.json without scriptFile #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

Add a default script_file to support function.json without scriptFile #893

merged 1 commit into from
Sep 23, 2021

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Sep 22, 2021 •
edited
Loading

Description

Some function.json files do not contain scriptFile property and that can cause the app to fail.

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr requested a review from AnatoliB as a code owner September 22, 2021 23:52
sidkri
sidkri reviewed Sep 23, 2021
View reviewed changes
pgombar
pgombar approved these changes Sep 23, 2021
View reviewed changes
Copy link

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@vrdmr vrdmr merged commit 4da437d into dev Sep 23, 2021
@vrdmr vrdmr deleted the vameru/add_default_script_file branch September 23, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidkri sidkri sidkri approved these changes

@pragnagopa pragnagopa pragnagopa approved these changes

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

+1 more reviewer

@pgombar pgombar pgombar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrdmr @pragnagopa @pgombar @sidkri