Categorize SDK logs as system logs #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
reviewed
May 13, 2021
vrdmr
approved these changes
Jun 2, 2021
| @@ -20,6 +19,15 @@ | |||
|
|
|||
|
|
|||
| class TestLogFilteringFunctions(testutils.WebHostTestCase): | |||
| """This class is for testing the logger behavior in Python Worker when | |||
| dealing with customer's log and system's log. Here's a list of expected | |||
| behaviors: | |||
There was a problem hiding this comment.
nit; you don't need to mention this - if you have mentioned this earlier. Just give a reference of is_system_log_category and that should be good enough.
| @@ -50,6 +58,7 @@ def check_log_debug_logging(self, host_out: typing.List[str]): | |||
| self.assertIn('logging info', host_out) | |||
| self.assertIn('logging warning', host_out) | |||
| self.assertIn('logging error', host_out) | |||
| # See HOST_JSON_TEMPLATE_WITH_LOGLEVEL_INFO, debug log is disabled | |||
There was a problem hiding this comment.
Sorry - didnt understand this - where is this pointing to?
| Here's a list of expected behaviors: | ||
| local_console customer_app_insight functions_kusto_table | ||
| system_log false false true | ||
| customer_log true true false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependency Azure/azure-functions-python-library#88
Fixes ##840
From now on, we will treat 'azure.functions' namespace and its child namespace as system logs.
After merging this PR, we should be able to see the following log lines in our Kusto table:
This will help the PM team calculate the usage on WSGI/ASGI middlewares.
Core changes in
azure_functions_worker/logging.py.cc: @stefanushinardi @vrdmr @AnatoliB
PR information
Quality of Code and Contribution Guidelines