Skip to content

Drop GRPC message size limitation #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2020
Merged

Drop GRPC message size limitation #632

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0bbb947
Increase message size to sys.maxsize
Mar 16, 2020
e4ccd6d
Update testing function host to 2.0.13036
Mar 16, 2020
30f6d12
Set message limitation on -1
Mar 16, 2020
b51e0c9
Fix code quality
Mar 16, 2020
2acaf93
Improve debug flag consistency
Mar 17, 2020
1269103
Fix DOTNET_VERSION incompatibility
Mar 17, 2020
325b17b
Upgrade pip before resolving dependencies
Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions azure_functions_worker/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@


import argparse
import sys

from . import aio_compat
from . import dispatcher
Expand Down Expand Up @@ -36,17 +37,16 @@ def main():

try:
return aio_compat.run(start_async(
args.host, args.port, args.worker_id, args.request_id,
args.grpc_max_msg_len))
args.host, args.port, args.worker_id, args.request_id))
except Exception:
error_logger.exception('unhandled error in functions worker')
raise


async def start_async(host, port, worker_id, request_id, grpc_max_msg_len):
async def start_async(host, port, worker_id, request_id):
disp = await dispatcher.Dispatcher.connect(
host, port, worker_id, request_id,
connect_timeout=5.0, max_msg_len=grpc_max_msg_len)
connect_timeout=5.0, max_msg_len=sys.maxsize)

disp.load_bindings()

Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@


# TODO: change this to something more stable when available.
WEBHOST_URL = ('https://ci.appveyor.com/api/buildjobs/1fqp92o5h2gks7xe'
WEBHOST_URL = ('https://ci.appveyor.com/api/buildjobs/19gqd7drpxhkedea'
'/artifacts'
'/Functions.Binaries.2.0.12888.no-runtime.zip')
'/Functions.Binaries.2.0.13036.no-runtime.zip')

# Extensions necessary for non-core bindings.
AZURE_EXTENSIONS = """\
Expand Down