-
Notifications
You must be signed in to change notification settings - Fork 107
feat: SDK bindings changes #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 159 commits
Commits
Show all changes
160 commits
Select commit
Hold shift + click to select a range
a6df3c0
sdk working prototype
hallvictoria 532549c
misc
hallvictoria ad66487
merge with dev
hallvictoria 468fdbb
new registry pseudo
hallvictoria 0e2aabd
prototype changes
hallvictoria ecaced1
weird dispatcher changes
hallvictoria 3fda7b7
almost works
hallvictoria 180e3e7
working prototype!!
hallvictoria f60ce9a
reset flag
hallvictoria fd888dc
support for mix & match in same func
hallvictoria abf92b9
added pytype to decode()
hallvictoria bc2e719
caching
hallvictoria 54c2ca9
added tests
hallvictoria 28620e4
revert later
hallvictoria 3f50987
lint, clean up, templates
hallvictoria 79fe387
Merge branch 'dev' into hallvictoria/sdk-bindings
hallvictoria e2aa249
reorder
hallvictoria ba506b9
merge
hallvictoria c8741a3
reorder again
hallvictoria 29c8f5d
test pypi problems
hallvictoria 7dabadb
correct dir
hallvictoria dda46a7
checking tests
hallvictoria 24be05e
Merge branch 'dev' into hallvictoria/sdk-bindings
hallvictoria 950310b
404s
hallvictoria e61f551
Merge branch 'hallvictoria/sdk-bindings' of https://github.com/Azure/…
hallvictoria 0bdaa29
investigating 500s
hallvictoria b1f7510
no cache
hallvictoria 5ac3503
debugging
hallvictoria 7c102b8
more helpful debugging
hallvictoria e2bfe40
check raw bindings
hallvictoria 3834da1
runtime error
hallvictoria 0b90c69
runtime error logging attempt
hallvictoria 3e0423b
local logger
hallvictoria 971f26f
sys modules
hallvictoria 9edeed6
typo
hallvictoria 9ceddce
extensions version
hallvictoria c32082a
testing changes -- revert later
hallvictoria 0677af2
added host logs
hallvictoria 0b40754
spacing?
hallvictoria b9eb942
debugging changes
hallvictoria 5f06186
Moved dateutil to install_requires (#1443)
gavin-aguiar 967e067
Update Python Worker Version to 4.26.0
1c86b00
net8 target framework
hallvictoria 33e3d03
stdout is not none
hallvictoria 864f458
tests pass locally
hallvictoria d451301
Merge branch 'dev' of https://github.com/Azure/azure-functions-python…
hallvictoria ab94777
updating extension versions
hallvictoria 54a8731
temp table test fix
hallvictoria 2e4cfd9
table and eventhub test fix
hallvictoria cf155ec
all blob tests
hallvictoria 1ed33b4
Merge branch 'dev' of https://github.com/Azure/azure-functions-python…
98d0eca
merge with dev
de91a09
Merge branch 'hallvictoria/sdk-bindings' of https://github.com/Azure/…
9581929
no importlib
9c0fb6e
specific tests only for deferred bindings
cc629f9
removed -e
882615b
syntax
25a4ada
ignore test, add back in cache
7606f4a
revert eh and table tests
aedd917
blob extension resources
6a67832
>=3.9 support + test fixes
hallvictoria d235c36
lint
hallvictoria 8ffd054
removed testing changes
hallvictoria 8109cfe
lint again
hallvictoria 69b9d91
unit tests fix
hallvictoria 90e05e7
append to list
hallvictoria 5e644ce
fixes + tests
hallvictoria d532739
reset flag, extra test
hallvictoria c27ddbc
revert meta changes, tests passing locally
hallvictoria ae4f3d5
fixed tests
hallvictoria 72cf2d7
fix unit test, import by default
937780e
revert default import, meta refactoring
1c3be18
fixed meta refactor
hallvictoria cf03600
added tests for helpers
hallvictoria 8020ab9
type syntax
hallvictoria f13de2a
fixed tests
hallvictoria 0f77d5d
actually fixed tests
hallvictoria c295a4f
update base ext supported python version
hallvictoria 6dc75b9
fixing unit test timeouts?
hallvictoria 22ae2a0
setup.py too
hallvictoria 78eef60
installing from .[deferred-bindings]
df12dc0
update base ext supported python version again
ff75823
update var name in setup.py
8591fec
update var name in meta
c2fd15d
refactor tests into sep folder
ac78e7b
lint + install only .NET6
9d40991
remove script
8367f9e
edit workflow
f04c0e3
import by default, misc fixes
f9fa310
revert, only changed var name
14beca7
get_binding check
fc47c14
revert get_binding check, import by default
e3933f1
lint
91bbc18
rename, replace None checks, comments
hallvictoria 2d70c05
fixed flag placement
hallvictoria e320a9e
attribute error + lint
hallvictoria 1411dec
fixed unit tests
hallvictoria 10a9039
yml bug/feature reports
hallvictoria e802d63
moving flag set out of get_binding
hallvictoria e80f37d
lint + 100
hallvictoria c9a63be
merge
f9e6952
add registry none check
hallvictoria 29aefda
Merge branch 'dev' into hallvictoria/sdk-bindings
hallvictoria 0937cd3
lint
hallvictoria 249d0cd
Merge branch 'hallvictoria/sdk-bindings' of https://github.com/Azure/…
hallvictoria 2dc368a
move check
hallvictoria b8c59f4
revert error raise
hallvictoria 109c078
changed order
hallvictoria a591055
revert flag set
hallvictoria 24fc8c1
loader registry none check
hallvictoria 19bfd5f
adding back in checks
hallvictoria 1b42eb8
reports & workflow feedback
hallvictoria 4c69c18
permissions + consumption
hallvictoria afb444a
feedback
hallvictoria bbf865a
setup.py
hallvictoria 21a7e0b
Merge branch 'dev' into hallvictoria/sdk-bindings
hallvictoria 11e5676
db test csproj
hallvictoria a59f90c
Merge branch 'hallvictoria/sdk-bindings' of https://github.com/Azure/…
hallvictoria 45e9066
remove 3.12
hallvictoria a72e2cc
combined db & e2e test workflow
hallvictoria cb8c7ce
fixed consumption workflow
hallvictoria 8c146e3
fixed 3.7 tests
hallvictoria a0920c1
skip all tests
hallvictoria af10930
renamed registries as constants
hallvictoria 6448eed
add flag as part of FunctionInfo + tests
hallvictoria 03871a8
lint
hallvictoria c0f5442
added logs (fails until new base)
hallvictoria 2deaad0
Merge branch 'dev' into hallvictoria/sdk-bindings
YunchuWang 40ef29b
lint + base update
7971498
changing bind_name (fails until exts)
762e5bd
Revert "changing bind_name (fails until exts)"
hallvictoria 8d74339
is_db property added to PTI
hallvictoria ec5f38e
fixed test
hallvictoria 06434a2
quick log
hallvictoria 94311f3
better log
hallvictoria e779583
lint
7081b0d
refactor FI + pin pip
37278b9
return cache val immediately
d565edb
install .[test-db] only for >=3.9
fc118cb
fixing installation
1922104
fixing installation pt2
a9a8fd2
fixing installation pt3
dbea0bb
sep step for installations
44a68f5
sep step for installations pt2
9c3188b
closed if + semicolon
cb12710
updated refs to base
d00d6e0
updated refs to blob (rerun later)
0669c44
update setup.py
hallvictoria 944d8cd
Merge branch 'dev' into hallvictoria/sdk-bindings
hallvictoria ea9b93d
remove import try/catch
hallvictoria 082d7ef
log bug fix
hallvictoria f10ccf4
unit tests
hallvictoria a3316f8
pin pip
hallvictoria 6fb251e
log if base not found
hallvictoria a7188ba
log delimiters
hallvictoria fe06530
removed f strings
hallvictoria a719a91
lint + feedback
hallvictoria 53bcc2e
pydocs + default val
hallvictoria a798640
get_raw_bindings method
hallvictoria 9eb0959
var names + docs
hallvictoria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| name: Python Worker Deferred Bindings Feature Request | ||
| description: File a Deferred Bindings bug report | ||
| title: "[Bug] Bug Title Here" | ||
| labels: ["python", "bug", "deferred-bindings"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| This form will help you to fill in a bug report for the Azure Functions Python Worker Deferred Bindings feature. | ||
|
|
||
| - type: textarea | ||
| id: expected-behavior | ||
| attributes: | ||
| label: Expected Behavior | ||
| description: A clear and concise description of what you expected to happen. | ||
| placeholder: What should have occurred? | ||
|
|
||
| - type: textarea | ||
| id: actual-behavior | ||
| attributes: | ||
| label: Actual Behavior | ||
| description: A clear and concise description of what actually happened. | ||
| placeholder: What went wrong? | ||
|
|
||
| - type: textarea | ||
| id: reproduction-steps | ||
| attributes: | ||
| label: Steps to Reproduce | ||
| description: Please provide detailed step-by-step instructions on how to reproduce the bug. | ||
| placeholder: | | ||
| 1. Go to the [specific page or section] in the application. | ||
| 2. Click on [specific button or link]. | ||
| 3. Scroll down to [specific location]. | ||
| 4. Observe [describe what you see, e.g., an error message or unexpected behavior]. | ||
| 5. Include any additional steps or details that may be relevant. | ||
|
|
||
| - type: textarea | ||
| id: code-snippet | ||
| attributes: | ||
| label: Relevant code being tried | ||
| description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. | ||
| render: shell | ||
|
|
||
| - type: textarea | ||
| id: logs | ||
| attributes: | ||
| label: Relevant log output | ||
| description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. | ||
| render: shell | ||
|
|
||
| - type: textarea | ||
| id: requirements | ||
| attributes: | ||
| label: requirements.txt file | ||
| description: Please copy and paste your requirements.txt file. This will be automatically formatted into code, so no need for backticks. | ||
| render: shell | ||
|
|
||
| - type: dropdown | ||
| id: environment | ||
| attributes: | ||
| label: Where are you facing this problem? | ||
| default: 0 | ||
| options: | ||
| - Local - Core Tools | ||
| - Production Environment (explain below) | ||
|
|
||
| - type: textarea | ||
| id: additional-info | ||
| attributes: | ||
| label: Additional Information | ||
| description: Add any other information about the problem here. | ||
36 changes: 36 additions & 0 deletions
36
.github/ISSUE_TEMPLATE/deferred_bindings_feature_request.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Python Worker Deferred Bindings Feature Request | ||
| description: File a Deferred Bindings Feature report | ||
| title: "Request a feature" | ||
| labels: ["python", "feature", "deferred-bindings"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| This form will help you to fill in a feature request for the Azure Functions Python Worker Deferred Bindings feature. | ||
|
|
||
| - type: textarea | ||
| id: binding-type | ||
| attributes: | ||
| label: Binding Type | ||
| description: Add information about the binding type. | ||
| placeholder: Is this on an existing binding or new binding? | ||
|
|
||
| - type: textarea | ||
| id: expected-behavior | ||
| attributes: | ||
| label: Expected Behavior | ||
| description: A clear and concise description of what you expected to happen. | ||
| placeholder: What should have occurred? | ||
|
|
||
| - type: textarea | ||
| id: code-snippet | ||
| attributes: | ||
| label: Relevant sample code snipped | ||
| description: Please copy and paste any relevant code snippet of how you want the feature to be used. (This will be automatically formatted into code, so no need for backticks) | ||
| render: shell | ||
|
|
||
hallvictoria marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - type: textarea | ||
| id: additional-info | ||
| attributes: | ||
| label: Additional Information | ||
| description: Add any other information about the problem here. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| #!/usr/bin/env bash | ||
| python -m pytest -q -n auto --dist loadfile --reruns 4 --instafail --cov=./azure_functions_worker --cov-report xml --cov-branch --cov-append tests/endtoend/test_worker_process_count_functions.py tests/endtoend/test_threadpool_thread_count_functions.py | ||
| python -m pytest -q -n auto --dist loadfile --reruns 4 --instafail --cov=./azure_functions_worker --cov-report xml --cov-branch --cov-append --ignore=tests/endtoend/test_worker_process_count_functions.py --ignore=tests/endtoend/test_threadpool_thread_count_functions.py tests/endtoend | ||
| python -m pytest -q -n auto --dist loadfile --reruns 4 --instafail --cov=./azure_functions_worker --cov-report xml --cov-branch --cov-append --ignore=tests/endtoend/test_worker_process_count_functions.py --ignore=tests/endtoend/test_threadpool_thread_count_functions.py tests/endtoend | ||
| python -m pytest -q -n auto --dist loadfile --reruns 4 --instafail --cov=./azure_functions_worker --cov-report xml --cov-branch --cov-append tests/extension_tests/deferred_bindings_tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.