Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions azure/functions/_http_asgi.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

import asyncio
from typing import Callable, Dict, List, Tuple, Optional, Any, Union
from typing import Dict, List, Tuple, Optional, Any, Union
import logging
import asyncio
from wsgiref.headers import Headers

from ._abc import Context
Expand Down Expand Up @@ -104,32 +104,31 @@ async def _send(self, message):


class AsgiMiddleware:
_logger = logging.getLogger('azure.functions.AsgiMiddleware')
_usage_reported = False

def __init__(self, app):
logging.debug("Instantiating ASGI middleware.")
self._app = app
self.loop = asyncio.new_event_loop()
logging.debug("asyncio event loop initialized.")
if not self._usage_reported:
self._logger.info("Instantiating Azure Functions ASGI middleware.")
self._usage_reported = True

# Usage
# main = func.AsgiMiddleware(app).main
@property
def main(self) -> Callable[[HttpRequest, Context], HttpResponse]:
return self._handle
self._app = app
self._loop = asyncio.new_event_loop()
self.main = self._handle

# Usage
# return func.AsgiMiddleware(app).handle(req, context)
def handle(
self, req: HttpRequest, context: Optional[Context] = None
) -> HttpResponse:
logging.info(f"Handling {req.url} as ASGI request.")
def handle(self, req: HttpRequest, context: Optional[Context] = None):
self._logger.debug(f"Handling {req.url} as an ASGI request.")
return self._handle(req, context)

def _handle(self, req: HttpRequest,
context: Optional[Context]) -> HttpResponse:
# Usage
# main = func.AsgiMiddleware(app).main
def _handle(self, req, context):
asgi_request = AsgiRequest(req, context)
asyncio.set_event_loop(self.loop)
asyncio.set_event_loop(self._loop)
scope = asgi_request.to_asgi_http_scope()
asgi_response = self.loop.run_until_complete(
asgi_response = self._loop.run_until_complete(
AsgiResponse.from_app(self._app, scope, req.get_body())
)

Expand Down
27 changes: 14 additions & 13 deletions azure/functions/_http_wsgi.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

from typing import Callable, Dict, List, Optional, Any
from typing import Dict, List, Optional, Any
import logging
from io import BytesIO, StringIO
from os import linesep
from urllib.parse import urlparse
Expand Down Expand Up @@ -142,26 +143,26 @@ def _start_response(self, status: str, response_headers: List[Any]):


class WsgiMiddleware:
_logger = logging.getLogger('azure.functions.WsgiMiddleware')
_usage_reported = False

def __init__(self, app):
if not self._usage_reported:
self._logger.info("Instantiating Azure Functions WSGI middleware.")
self._usage_reported = True

self._app = app
self._wsgi_error_buffer = StringIO()

# Usage
# main = func.WsgiMiddleware(app).main
@property
def main(self) -> Callable[[HttpRequest, Context], HttpResponse]:
return self._handle
self.main = self._handle

# Usage
# return func.WsgiMiddleware(app).handle(req, context)
def handle(self,
req: HttpRequest,
context: Optional[Context] = None) -> HttpResponse:
def handle(self, req: HttpRequest, context: Optional[Context] = None):
return self._handle(req, context)

def _handle(self,
req: HttpRequest,
context: Optional[Context]) -> HttpResponse:
# Usage
# main = func.WsgiMiddleware(app).main
def _handle(self, req, context):
wsgi_request = WsgiRequest(req, context)
environ = wsgi_request.to_environ(self._wsgi_error_buffer)
wsgi_response = WsgiResponse.from_app(self._app, environ)
Expand Down
15 changes: 15 additions & 0 deletions tests/test_http_asgi.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,18 @@ def test_middleware_calls_app_with_context(self):
# Verify asserted
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_body(), test_body)

def test_middleware_wrapper(self):
app = MockAsgiApplication()
test_body = b'Hello world!'
app.response_body = test_body
app.response_code = 200
req = self._generate_func_request()
ctx = self._generate_func_context()

main = AsgiMiddleware(app).main
response = main(req, ctx)

# Verify asserted
self.assertEqual(response.status_code, 200)
self.assertEqual(response.get_body(), test_body)
10 changes: 10 additions & 0 deletions tests/test_http_wsgi.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,16 @@ def test_middleware_handle(self):
func_request = self._generate_func_request()
func_response = WsgiMiddleware(app).handle(func_request)
self.assertEqual(func_response.status_code, 200)
self.assertEqual(func_response.get_body(), b'sample string')

def test_middleware_wrapper(self):
app = self._generate_wsgi_app()
main = WsgiMiddleware(app).main
func_request = self._generate_func_request()
func_context = self._generate_func_context()
func_response = main(func_request, func_context)
self.assertEqual(func_response.status_code, 200)
self.assertEqual(func_response.get_body(), b'sample string')

def _generate_func_request(
self,
Expand Down