feat: additional configurations for Kafka Trigger and Output #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloiva
commented
Nov 14, 2025
aloiva
commented
- Adds configurations for kafka trigger and output.
- Taken from KafkaTriggerAttribute, KafkaAttribute
aloiva
requested review from
gavin-aguiar,
hallvictoria and
vrdmr
as code owners
aloiva
changed the title
| :param key_avro_schema: Avro schema for the message key. Used only if a | ||
| generic Avro record should be generated for the key. | ||
| :param key_data_type: Data type of the message key. Valid values: Int, Long, | ||
| String, Binary. Default is String. Ignored if key_avro_schema is set. |
Contributor
There was a problem hiding this comment.
Could you please also add pydocs for the new ssl_ arguments as well here?
| consumer_group: Optional[str] = None, | ||
| avro_schema: Optional[str] = None, | ||
| key_avro_schema: Optional[str] = None, | ||
| key_data_type: Optional[Union[KafkaMessageKeyType, str]] = None, |
Contributor
There was a problem hiding this comment.
Could you set the default value for key_data_type to KafkaMessageKeyType.STRING here since it's given a default value in kafka.py?
| broker_list: str, | ||
| avro_schema: Optional[str] = None, | ||
| key_avro_schema: Optional[str] = None, | ||
| key_data_type: Optional[Union[KafkaMessageKeyType, str]] = None, |
Contributor
There was a problem hiding this comment.
Same as trigger - please set default value here to match kafka.py
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.