-
Notifications
You must be signed in to change notification settings - Fork 71
Naive implementation of a backwards-compatible function_name decorator
#202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cf6a425
Implement backwards compatibility for function_name
davidmrdavid 4438f56
Moving function_name to decoratorapi
gavin-aguiar c7b2cbe
Fixed flake8 validation
gavin-aguiar c338f9a
Merge branch 'dev' into dajusto/backwards-compat
gavin-aguiar 39f3a57
Merge branch 'dev' into dajusto/backwards-compat
hallvictoria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,10 +11,10 @@ | |
| TIMER_TRIGGER | ||
| from azure.functions.decorators.core import DataType, AuthLevel, \ | ||
| BindingDirection, SCRIPT_FILE_NAME | ||
| from azure.functions.decorators.function_app import FunctionBuilder, \ | ||
| FunctionApp, Function, Blueprint, DecoratorApi, AsgiFunctionApp, \ | ||
| WsgiFunctionApp, HttpFunctionsAuthLevelMixin, FunctionRegister, \ | ||
| TriggerApi, ExternalHttpFunctionApp | ||
| from azure.functions.decorators.function_app import BindingApi, \ | ||
| FunctionBuilder, FunctionApp, Function, Blueprint, DecoratorApi, \ | ||
| AsgiFunctionApp, WsgiFunctionApp, HttpFunctionsAuthLevelMixin, \ | ||
| FunctionRegister, TriggerApi, ExternalHttpFunctionApp | ||
| from azure.functions.decorators.http import HttpTrigger, HttpOutput, \ | ||
| HttpMethod | ||
| from azure.functions.decorators.retry_policy import RetryPolicy | ||
|
|
@@ -489,6 +489,31 @@ def hello(name: str): | |
| self.assertEqual(setting.get_settings_value("function_name"), | ||
| "timer_function") | ||
|
|
||
| def test_legacy_blueprints_with_function_name(self): | ||
| class LegacyBluePrint(TriggerApi, BindingApi): | ||
| pass | ||
|
|
||
|
Comment on lines
+493
to
+495
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. notice this doesn't inherit from SettingsApi :) |
||
| class DummyFunctionApp(FunctionRegister, TriggerApi): | ||
| pass | ||
|
|
||
| app = DummyFunctionApp(auth_level=AuthLevel.ANONYMOUS) | ||
| blueprint = LegacyBluePrint() | ||
|
|
||
| @blueprint.function_name("timer_function") | ||
| @blueprint.schedule(arg_name="name", schedule="10****") | ||
| def hello(name: str): | ||
| return name | ||
|
|
||
| app.register_blueprint(blueprint) | ||
|
|
||
| functions = app.get_functions() | ||
| self.assertEqual(len(functions), 1) | ||
|
|
||
| setting = functions[0].get_setting("function_name") | ||
|
|
||
| self.assertEqual(setting.get_settings_value("function_name"), | ||
| "timer_function") | ||
|
|
||
| def test_function_register_register_function_register_error(self): | ||
| class DummyFunctionApp(FunctionRegister): | ||
| pass | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.