Skip to content

Add capabilities update strategy to environment reload response #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satvu merged 6 commits into from
Jul 14, 2023
Merged

Add capabilities update strategy to environment reload response #95

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1bdc6c
initial wip
satvu Jul 7, 2023
a775b01
update strategies enum
satvu Jul 10, 2023
0e2e68a
update comment
satvu Jul 10, 2023
f7a068b
resolve comments
satvu Jul 11, 2023
0ef1add
update comment
satvu Jul 11, 2023
a088a33
add clarifying comment for default strat, add examples
satvu Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/proto/FunctionRpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,14 @@ message FunctionEnvironmentReloadRequest {
}

message FunctionEnvironmentReloadResponse {
enum CapabilitiesUpdateStrategy {
// overwrites existing values and appends new ones
// ex. worker init: {A: foo, B: bar} + env reload: {A:foo, B: foo, C: foo} -> {A: foo, B: foo, C: foo}
merge = 0;
// existing capabilities are cleared and new capabilities are applied
// ex. worker init: {A: foo, B: bar} + env reload: {A:foo, C: foo} -> {A: foo, C: foo}
replace = 1;
}
// After specialization, worker sends capabilities & metadata.
// Worker metadata captured for telemetry purposes
WorkerMetadata worker_metadata = 1;
Expand All @@ -254,6 +262,9 @@ message FunctionEnvironmentReloadResponse {

// Status of the response
StatusResult result = 3;

// If no strategy is defined, the host will default to merge
CapabilitiesUpdateStrategy capabilities_update_strategy = 4;
}

// Tell the out-of-proc worker to close any shared memory maps it allocated for given invocation
Expand Down