Add capabilities and worker_metadata in env reload response. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
requested review from
AnatoliB,
Francisco-Gamino,
YunchuWang,
alrod,
amamounelsayed,
ejizba,
gavin-aguiar,
kaibocai,
satvu,
shreyas-gopalakrishna,
surgupta-msft and
vrdmr
as code owners
jviau
approved these changes
Dec 21, 2022
surgupta-msft
approved these changes
Dec 21, 2022
kshyju
commented
Dec 21, 2022
kashimiz
approved these changes
Dec 21, 2022
liliankasem
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capabilities and worker metadata in env reload response. This is to support changes needed for Azure/azure-functions-host#8983
Currently worker metadata and capabilities are sent in the worker init response. But this is not valid for placeholder & specialization use case. When in placeholder mode, this information is not available. It is available only after specialization (env reload request). So we need to include this information in the env reload response.
I added 1 and 2 as the order for these new props as the existing
resultproperty(the only property existed in this type) was using 3. I looked at this history of this and found that PR #20 added this type and status property. This type never had a property with order value 1 and 2. So I am guessing this will not break anything.