Skip to content

Conversation

@yojagad
Copy link
Contributor

@yojagad yojagad commented Sep 10, 2019

@yojagad yojagad changed the title Accept Activity id to flow to out of proc languages Accept Trace context to flow to out of proc languages Sep 13, 2019
@yojagad yojagad requested review from liudawid and lmolkova and removed request for liudawid September 13, 2019 00:22
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename

Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is valid to have null or empty valued attributes, please change! Otherwise LGTM

Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants