Skip to content

Additional Annotations for Kafka Trigger and Output Binding #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2023
Merged

Additional Annotations for Kafka Trigger and Output Binding #200

merged 4 commits into from
Sep 21, 2023

Conversation

jainharsh98
Copy link
Contributor

@jainharsh98 jainharsh98 commented Aug 22, 2023 •
edited
Loading

The PR aims at adding annotations for recently added features in Kafka extension for Java Functions.

For Kafka Trigger -

  1. lagThreshold
  2. schemaRegistryUrl
  3. schemaRegsitryUsername
  4. schemaRegistryPassword

For Kafka Output -

  1. lingerMs
  2. schemaRegistryUrl
  3. schemaRegsitryUsername
  4. schemaRegistryPassword
  5. avroSchema

@jainharsh98
Copy link
Contributor Author

Should resolve #200 and #199.

@jainharsh98 jainharsh98 marked this pull request as draft August 22, 2023 05:44
@jainharsh98 jainharsh98 marked this pull request as ready for review September 12, 2023 12:13
@jainharsh98
Copy link
Contributor Author

@kaibocai Can you please help merge the PR?

@kaibocai kaibocai merged commit 324ea3f into Azure:dev Sep 21, 2023
@shreyas-gopalakrishna shreyas-gopalakrishna mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jainharsh98 @kaibocai