Skip to content

[pack]Increase gRpc Server max message size #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2020
Merged

[pack]Increase gRpc Server max message size #5801

merged 2 commits into from
Mar 17, 2020

Conversation

@pragnagopa
Copy link
Member

@pragnagopa pragnagopa commented Mar 17, 2020

Fixes #5650

@pragnagopa pragnagopa requested review from mhoeger and yojagad March 17, 2020 15:07
mhoeger
mhoeger reviewed Mar 17, 2020
View reviewed changes
src/WebJobs.Script.Grpc/Server/GrpcServer.cs
private Server _server;
private bool _disposed = false;
public const int MaxMessageLengthBytes = 128 * 1024 * 1024;
public const int MaxMessageLengthBytes = int.MaxValue;
Copy link
Contributor

@mhoeger mhoeger Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to int.MaxValue too?
https://github.com/Azure/azure-functions-host/blob/dev/src/WebJobs.Script/Workers/Rpc/RpcWorkerConstants.cs#L31

Copy link
Contributor

@yojagad yojagad Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance we could start run into timeout issues the payload size is close to this new max ?

Copy link
Member Author

@pragnagopa pragnagopa Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @mhoeger. Fixed it.

@yojagad - there is a chance that app might run into out-of-memory exception which is by design.

mhoeger
mhoeger approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@pragnagopa pragnagopa merged commit 48256b7 into Azure:dev Mar 17, 2020
yojagad pushed a commit that referenced this pull request Apr 20, 2020
@pragnagopa @yojagad
[pack]Increase gRpc Server max message size (#5801)
ff50c0d
yojagad pushed a commit that referenced this pull request Apr 21, 2020
@pragnagopa @yojagad
[pack]Increase gRpc Server max message size (#5801)
f44a70f
fabiocav pushed a commit that referenced this pull request Apr 22, 2020
@pragnagopa @fabiocav
[pack]Increase gRpc Server max message size (#5801)
cfb3a09
@bytemech bytemech mentioned this pull request Jun 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yojagad yojagad yojagad approved these changes

+1 more reviewer

@mhoeger mhoeger mhoeger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Grpc]Increase MaxMessageLength to int.MaxValue

3 participants

@pragnagopa @mhoeger @yojagad