dispose ILoggerFactory in ScriptHost #1892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
approved these changes
Sep 12, 2017
brettsam
force-pushed
the
loggerdispose
branch
2 times, most recently
from
1855307 to
4f15673
Compare
brettsam
force-pushed
the
loggerdispose
branch
from
4f15673 to
ff8ac4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race fixed with #1876 means that we should be able to dispose of the ILoggerFactory again. This is useful because it disposes of everything being used by the TelemetryClient and also flushes any outstanding telemetry.
Taking a different approach this time -- since the ScriptHost is creating the LoggerFactory, it should be responsible for disposing it. Previously, I was disposing it in the JobHostContext in the SDK repo.
My testing (explained in #1690) leads me to believe that the race is fixed, but it's tough to prove 100%. I'll be monitoring the next rollout to make sure that I don't see any of these ObjectDisposedExceptions getting thrown.