Skip to content

Conversation

@kshyju
Copy link
Member

@kshyju kshyju commented Apr 25, 2024

backporting #9997

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

…d. (#9997)

* Include route params in RpcHttp instance when http proxying is enabled.

* Fixes to address PR comments.
@kshyju kshyju requested a review from a team as a code owner April 25, 2024 20:57
@fabiocav
Copy link
Member

Any changes required when backporting, or was the commit coming in as-is?

@kshyju
Copy link
Member Author

kshyju commented Apr 26, 2024

Any changes required when backporting, or was the commit coming in as-is?

Cherry picking the commit as it is. In this change, we don't use any language features which does not work for .NET6. Do you see any issues?

@fabiocav
Copy link
Member

Cherry picking the commit as it is. In this change, we don't use any language features which does not work for .NET6. Do you see any issues?

No issues. Just checking if there was anything else that required attention.

@kshyju kshyju merged commit 2462997 into in-proc Apr 27, 2024
@kshyju kshyju deleted the shkr/in-proc_backport_9997 branch April 27, 2024 03:11
fabiocav pushed a commit that referenced this pull request Apr 29, 2024
…d. (#9997) (#10072)

* Include route params in RpcHttp instance when http proxying is enabled.

* Fixes to address PR comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants