Skip to content

Update python library to 1.2.0, add get_input #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 3, 2020
Merged

Update python library to 1.2.0, add get_input #60

merged 8 commits into from
Mar 3, 2020

Conversation

anthonychu
Copy link
Member

  • Bump azure-functions dependency to 1.2.0
  • Add get_input
  • Expose DurableOrchestrationContext

@anthonychu
Copy link
Member Author

After our standup yesterday we decided we can try submitting this as a PR. Added tests.

@anthonychu anthonychu mentioned this pull request Mar 3, 2020
Merged
scgbear
scgbear approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@scgbear scgbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. I do like the impact the context being a first class citizen and moving the context.body bits into the create makes on the samples.

azure/durable_functions/models/DurableOrchestrationContext.py
@@ -23,7 +23,7 @@ class DurableOrchestrationContext:
# noinspection PyPep8Naming
def __init__(self,
history: List[Dict[Any, Any]], instanceId: str, isReplaying: bool,
parentInstanceId: str, **kwargs):
parentInstanceId: str, input: Any = None, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it there! if left in the kwargs, it would be duplicated onto the FunctionContext object

@anthonychu anthonychu merged commit de04569 into Azure:dev Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scgbear scgbear scgbear approved these changes

@priyaananthasankar priyaananthasankar Awaiting requested review from priyaananthasankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthonychu @scgbear @priyaananthasankar