revert: homeaz on nodeinfocrd #4065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d66b2f9.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes related to homeaz functionality on NodeInfo CRD, removing the homeaz field population and associated test coverage.
- Removes homeaz field from NodeInfo CRD creation and updates
- Removes comprehensive test coverage for homeaz functionality
- Updates Docker image SHA references for CNS and CNI components
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cns/service/main_test.go | Removes test for homeaz population and mock transport infrastructure |
| cns/service/main.go | Removes homeaz field from NodeInfo CRD and CNS client integration |
| cns/Dockerfile | Updates Go base image SHA |
| cni/Dockerfile | Updates Go base image SHA |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
csfmomo
approved these changes
Oct 6, 2025
rbtr
approved these changes
Oct 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nairashu
reviewed
Oct 8, 2025
nairashu
reviewed
Oct 8, 2025
nairashu
reviewed
Oct 8, 2025
nairashu
approved these changes
Oct 8, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Revert https://github.com/Azure/azure-container-networking/pull/4009/files#diff-3c6ba0ad51f93dc5c172cd00978b989c8c63d2b8d799f8d58d56c983b6498cce
Issue Fixed:
Requirements:
Notes: