ci: fix nightly pipeline cluster name reference #3656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the reference to the cluster name in the nightly pipeline for Cilium deployment, ensuring that the correct cluster name is used.
- Updated the cluster name construction in the nightly-release-test YAML script
- Replaced pipeline parameter syntax with shell variable substitution to include the commit ID in the cluster name
Comments suppressed due to low confidence (1)
.pipelines/cni/cilium/nightly-release-test.yml:162
- The change from pipeline parameter syntax '${{ parameters.clusterName }}' to shell variable substitution '$(clusterName)' may lead to undefined variables if 'clusterName' and 'commitID' are not properly set as environment variables. Consider verifying that these variables are exported or defined in the script context or revert to the original syntax if the intent was to use pipeline parameters.
make -C ./hack/aks set-kubeconf AZCLI=az CLUSTER=$(clusterName)-$(commitID)
jpayne3506
approved these changes
May 13, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
santhoshmprabhu
approved these changes
May 14, 2025
vipul-21
approved these changes
May 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
fix cluster name reference to unblock nightly pipeline
Issue Fixed:
Requirements:
Notes: