[SQL] az sql midb log-replay start: Add --storage-identity parameter
#24105
Conversation
|
SQL |
milanbrkic-ms
changed the title
milanbrkic-ms
requested review from
jsntcy,
kairu-ms and
necusjz
as code owners
milanbrkic-ms
changed the title
az sql midb log-replay start: Add --storage-identity parameter
|
/azp run |
|
Commenter does not have sufficient privileges for PR 24105 in repo Azure/azure-cli |
yonzhan
modified the milestones:
Oct 2022 (2022-11-01),
Sep 2022 (2022-10-12) - For Ignite
|
@evelyn-ys can you help with review? Thanks |
| @ResourceGroupPreparer(name_prefix='clitest-HSEP', location='eastus2') | ||
| @SqlServerPreparer(name_prefix='clitest-HSEP', location='eastus2') | ||
| @AllowLargeResponse() | ||
| @live_only() # Could not find tier Hyperscale. Supported tiers are: ['Standard', 'Premium', 'Basic', 'GeneralPurpose', 'BusinessCritical'] |
There was a problem hiding this comment.
Is this a breaking change that Hyperscale not supported any more in azure-mgmt-sql==4.0.0b4?
There was a problem hiding this comment.
I spoke with engineer who implemented this, and she said that Hyperscale type is still not publicly available. She confirmed that I can skip the test
| @ResourceGroupPreparer(location='eastus') | ||
| @SqlServerPreparer(location='eastus') | ||
| @KeyVaultPreparer(location='eastus', name_prefix='sqltdebyok') | ||
| @live_only() # User tried to log in to a device from a platform (Unknown) that's currently not supported through Conditional Access policy. Supported device platforms are: iOS, Android, Mac, and Windows flavors. |
There was a problem hiding this comment.
Did you run this test locally or in some agent? The error msg is rarely seen. I hope this test can be kept as it can pass all previous bumping versions.
There was a problem hiding this comment.
I am running all tests from Powershell 7.
There was a problem hiding this comment.
Test is failing on keyvault command, so I do not think my changes could break command in different module.
There was a problem hiding this comment.
Which keyvault command did it fail in? I have never met User tried to log in to a device from a platform (Unknown) that's currently not supported error before... Why would this test using conditional access policy😂
There was a problem hiding this comment.
This PR is ready for merge. Do you want me to merge it directly or figure out the root cause of keyvault failure then merge after fix?
There was a problem hiding this comment.
This is in KeyVaultPreparer if I am reading it correctly
There was a problem hiding this comment.
This PR is ready for merge. Do you want me to merge it directly or figure out the root cause of keyvault failure then merge after fix?
How do you prefer? I am fine with both, just to make it in the next release
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
The code LGTM but I just want that those tests marked as live_only can be fixed in case there's any unexpected breaking change during bumping 4.0.0b4
|
Sorry I have to move this PR to next release milestone |
evelyn-ys
modified the milestones:
Sep 2022 (2022-10-12) - For Ignite,
Oct 2022 (2022-11-01)
|
@evelyn-ys pls review again |
|
@evelyn-ys can you please merge this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@wangzelin007 Can you help merge this PR? |
…ter (Azure#24105) * bump version * add new parameter * record failing tests * more tests rec * more fixing * put corrrect mask * one more * zone tests recorded on eastus Co-authored-by: Milan Brkic <[email protected]>
6 participants
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.