{Network} Fix test_private_endpoint_connection_acfr, test_private_link_resource_acfr #20867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
approved these changes
Dec 30, 2021
Collaborator
|
Network |
yonzhan
approved these changes
Dec 30, 2021
wangzelin007
approved these changes
Dec 30, 2021
jiasli
reviewed
Dec 30, 2021
Comment on lines
40
to
41
Member
There was a problem hiding this comment.
If YAML is recorded again, Credential Scan will fail again.
Member
Author
There was a problem hiding this comment.
Better way is to use replacer to replace credentials. Just removing credential to quick fix CI failure.
Member
There was a problem hiding this comment.
It was previously manually replaced. That's why we hit this pitfall again: #19967 (comment).
jiasli
force-pushed
the
fix-redis-pe-tests
branch
from
4d419ff to
2fff23d
Compare
jiasli
changed the title
jiasli
approved these changes
Dec 30, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.