{Azurestack} ACR & AKS: Adding Tests and Fixing Authorization api-version for hybrid profile #18443

Bhuvaneswari-Santharam · 2021-06-10T18:26:58Z

Description

Testing Guide

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

yonzhan · 2021-06-11T00:37:05Z

Azurestack

Juliehzl · 2021-06-17T08:42:42Z

please make CI pass first

Bhuvaneswari-Santharam · 2021-06-23T09:15:12Z

@Juliehzl - All CI checks passed. Please review

Juliehzl · 2021-06-24T03:53:26Z

src/azure-cli-core/azure/cli/core/profiles/_shared.py

        ResourceType.MGMT_RESOURCE_TEMPLATESPECS: '2015-01-01',
        ResourceType.MGMT_NETWORK_DNS: '2016-04-01',
-        ResourceType.MGMT_AUTHORIZATION: SDKProfile('2016-09-01', {
+        ResourceType.MGMT_AUTHORIZATION: SDKProfile('2015-07-01', {


Is there a downgrade for authorization?

This is not a downgrade, This is a bug fix. In our earlier PR we have mistakenly updated the api version @Juliehzl

Juliehzl · 2021-06-25T06:51:43Z

src/azure-cli/azure/cli/command_modules/acr/check_health.py

-            from ._errors import CMK_MANAGED_IDENTITY_ERROR
-            _handle_error(CMK_MANAGED_IDENTITY_ERROR.format_error_message(registry_name), ignore_errors)
+    if cmd.supported_api_version(min_api='2020-11-01-preview', resource_type=ResourceType.MGMT_CONTAINERREGISTRY):  # pylint: disable=too-many-nested-blocks
+        # CMK settings


please also add acr code owner to review your change

@Bhuvaneswari-Santharam I tested this locally and it looks good. @northtyphoon we should consider adding some unit tests for acr check-health

adewaleo

Approved for ACR.
@Bhuvaneswari-Santharam I tested this locally and it looks good.
@northtyphoon we should consider adding some unit tests for acr check-health

yonzhan · 2021-06-30T01:37:23Z

@northtyphoon please add more unit tests as @adewaleo mentioned.

adewaleo · 2021-06-30T23:47:52Z

@northtyphoon please add more unit tests as @adewaleo mentioned.

@yonzhan, I was making this suggestion as a follow up item. Given acr check-health (convenience command for diagnosis) doesn't currently have unit tests. I did manually test to see that this change doesn't break acr check-health. I won't want this request to block @Bhuvaneswari-Santharam

FumingZhang

Need to update some recording files, since some of the tests failed.

.../command_modules/acs/tests/hybrid_2020_09_01/recordings/test_aks_availability_zones_msi.yaml

...cs/tests/hybrid_2020_09_01/recordings/test_aks_create_aadv1_and_update_with_managed_aad.yaml

...ests/hybrid_2020_09_01/recordings/test_aks_create_aadv1_and_update_with_managed_aad_msi.yaml

...ure/cli/command_modules/acs/tests/hybrid_2020_09_01/recordings/test_aks_create_blb_vmas.yaml

...cli/command_modules/acs/tests/hybrid_2020_09_01/recordings/test_aks_create_blb_vmas_msi.yaml

...2020_09_01/recordings/test_aks_create_slb_vmss_with_default_mgd_outbound_ip_then_update.yaml

...i/command_modules/acs/tests/hybrid_2020_09_01/recordings/test_aks_create_fqdn_subdomain.yaml

...nd_modules/acs/tests/hybrid_2020_09_01/recordings/test_openshift_create_default_service.yaml

...les/acs/tests/hybrid_2020_09_01/recordings/test_openshift_create_default_service_no_aad.yaml

...nd_modules/acs/tests/hybrid_2020_09_01/recordings/test_openshift_create_service_no_wait.yaml

Juliehzl · 2021-08-06T01:12:19Z

src/azure-cli/azure/cli/command_modules/acs/tests/hybrid_2020_09_01/test_acs_client.py

+
+# pylint: skip-file
+import unittest
+import mock


mock module is deprecated in azure cli. see #19024

FumingZhang

AKS test recordings looks good to me.

Juliehzl

mock module is deprecated in azure cli. see #19024

Juliehzl · 2021-08-06T07:22:38Z

src/azure-cli/azure/cli/command_modules/acr/tests/hybrid_2020_09_01/test_acr_commands_mock.py

+    from urllib import urlencode
+import json
+import unittest
+import mock


still have mock here.

Bhuvaneswari Santharam added 2 commits June 10, 2021 11:12

Changing hybrid authorization api-version

e00e9c9

Adding test for acs and acr hybrid profiles

b6eb4fc

Bhuvaneswari-Santharam requested review from Juliehzl, andyliuliming, evelyn-ys, fengzhou-msft, houk-ms, jiasli, jsntcy, kairu-ms, northtyphoon, yungezz and zqingqing1 as code owners June 10, 2021 18:26

bganapa approved these changes Jun 10, 2021

View reviewed changes

bganapa changed the title ~~[Azurestack][ACR][AKS]Change Authorization api-version for hybrid profile~~ [Azurestack][ACR][AKS] Adding Tests and Fixing Authorization api-version for hybrid profile Jun 10, 2021

yonzhan assigned Juliehzl Jun 11, 2021

yonzhan added this to the S189 milestone Jun 11, 2021

bganapa added the AzureStack label Jun 11, 2021

yonzhan added the Azure Stack label Jun 11, 2021

Juliehzl mentioned this pull request Jun 15, 2021

[Azurestack][ACR][AKS] add azurestack hybrid profile for AKS #18118

Merged

3 tasks

merge dev

6ac2e68

Bhuvaneswari-Santharam requested a review from zhoxing-ms as a code owner June 22, 2021 06:51

Bhuvaneswari Santharam added 4 commits June 22, 2021 01:02

adding azurestack check-health changes

a7de925

Acs hybrid test changes

0732048

Modifying Hybrid test for acr

c5c6dc4

Hybrid test acs

38e6a3b

Juliehzl reviewed Jun 24, 2021

View reviewed changes

Juliehzl reviewed Jun 25, 2021

View reviewed changes

adewaleo approved these changes Jun 30, 2021

View reviewed changes

Juliehzl approved these changes Jul 1, 2021

View reviewed changes

FumingZhang requested changes Jul 1, 2021

View reviewed changes

Bhuvaneswari Santharam added 2 commits June 30, 2021 23:40

Adding Aks hybrid test

f9865ec

merge acr test changes

7d43d85

yonzhan modified the milestones: S189, Jul 2021 (2021-08-03) Jul 2, 2021

jsntcy closed this Jul 26, 2021

jsntcy reopened this Jul 26, 2021

yonzhan modified the milestones: Jul 2021 (2021-08-03), Aug 2021 (2021-09-07) Jul 31, 2021

Hybrid profile test update

7c520b7

Bhuvaneswari-Santharam requested a review from FumingZhang August 5, 2021 08:51

yonzhan assigned zhoxing-ms Aug 5, 2021

Juliehzl reviewed Aug 6, 2021

View reviewed changes

FumingZhang approved these changes Aug 6, 2021

View reviewed changes

Juliehzl requested changes Aug 6, 2021

View reviewed changes

Drop mock for acs hybrid test

234ba1e

Bhuvaneswari-Santharam requested a review from Juliehzl August 6, 2021 07:02

Juliehzl reviewed Aug 6, 2021

View reviewed changes

Drop mock for acr hybrid test

086785c

Bhuvaneswari-Santharam requested a review from Juliehzl August 6, 2021 07:41

Juliehzl approved these changes Aug 6, 2021

View reviewed changes

Juliehzl merged commit 2693f38 into Azure:dev Aug 6, 2021

FumingZhang mentioned this pull request Aug 9, 2021

[AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in aks create sub-command #19157

Merged

3 tasks

evelyn-ys changed the title ~~[Azurestack][ACR][AKS] Adding Tests and Fixing Authorization api-version for hybrid profile~~ {Azurestack} ACR & AKS: Adding Tests and Fixing Authorization api-version for hybrid profile Sep 1, 2021

{Azurestack} ACR & AKS: Adding Tests and Fixing Authorization api-version for hybrid profile #18443

{Azurestack} ACR & AKS: Adding Tests and Fixing Authorization api-version for hybrid profile #18443

Uh oh!

Conversation

Bhuvaneswari-Santharam commented Jun 10, 2021 • edited by evelyn-ys Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Jun 11, 2021

Uh oh!

Juliehzl commented Jun 17, 2021

Uh oh!

Bhuvaneswari-Santharam commented Jun 23, 2021

Uh oh!

Juliehzl Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

bganapa Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

Juliehzl Jun 25, 2021

Choose a reason for hiding this comment

Uh oh!

adewaleo Jun 30, 2021

Choose a reason for hiding this comment

Uh oh!

adewaleo left a comment

Choose a reason for hiding this comment

Uh oh!

yonzhan commented Jun 30, 2021

Uh oh!

adewaleo commented Jun 30, 2021

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Juliehzl Aug 6, 2021

Choose a reason for hiding this comment

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Juliehzl left a comment

Choose a reason for hiding this comment

Uh oh!

Juliehzl Aug 6, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Bhuvaneswari-Santharam commented Jun 10, 2021 •

edited by evelyn-ys

Loading