Writing status file early in handler execution #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rane-rajasi
requested review from
a team,
benank and
kjohn-msft
and removed request for
a team
Collaborator
|
For later (separate task): [For now, don't write status for non-enable]
|
Collaborator
|
Review improvement based on when this goes in. See if this is sufficient or whether it needs to happen even faster. |
benank
approved these changes
Oct 6, 2021
kjohn-msft
reviewed
Oct 7, 2021
src/extension/src/ActionHandler.py
Outdated
Comment on lines
82
to
83
| status_json = self.ext_output_status_handler.read_file(seq_no) | ||
| if status_json is None: |
Collaborator
There was a problem hiding this comment.
Convert to basic file system exists check
kjohn-msft
reviewed
Oct 7, 2021
src/extension/src/ActionHandler.py
Outdated
Comment on lines
76
to
77
| seq_no = self.ext_config_settings_handler.get_seq_no() | ||
| if seq_no is None: |
Collaborator
There was a problem hiding this comment.
Only check env var for lightweight check (as discussed)
kjohn-msft
reviewed
Oct 7, 2021
kjohn-msft
reviewed
Oct 7, 2021
| file_path = os.path.join(dir_path, file_name) | ||
| error_message = "" | ||
| self.logger.log("Writing file. [File={0}]".format(file_name)) | ||
| self.logger.log("Writing file. [File={0}] [Content={1}]".format(file_name, str(content))) |
kjohn-msft
reviewed
Oct 7, 2021
| def mock_get_all_versions_exception(self, extension_pardir): | ||
| raise Exception | ||
|
|
||
| def mock_getenv(self, is_enable_request=False): |
kjohn-msft
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q: