Fix for patch install marked failed before implicit assessment #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirichmo
reviewed
Jul 6, 2021
| # Combining maintenance | ||
| overall_patch_installation_successful = bool(update_run_successful and not maintenance_window_exceeded) | ||
|
|
||
| if not overall_patch_installation_successful: |
Contributor
There was a problem hiding this comment.
Can you add a comment here stating why it is not marked error at this point?
kjohn-msft
approved these changes
Jul 7, 2021
mirichmo
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the 1st point mentioned in the description/1st comment in this PR: #70
Change was made earlier to only update patch installation substatus if the second/implicit assessment is completed. We missed out one place where the patch install status is marked 'Failed' before implicit assessment is complete. This again leads to the same issue at CRP where the availablePatchSummary remains 'InProgress' since the last status CRP reads is when Patch Install is marked Failed and while assessment is in progress.
Changes in this PR: