-
Notifications
You must be signed in to change notification settings - Fork 11
Fix excessive disk logging #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of https://github.com/Azure/LinuxPatchExtension into fix/pkg_mg_excessive_logging pull master changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 92.26% 92.42% +0.16%
==========================================
Files 96 97 +1
Lines 16105 16199 +94
==========================================
+ Hits 14859 14972 +113
+ Misses 1246 1227 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f6ae6ab to
422301f
Compare
kjohn-msft
reviewed
Jan 22, 2025
6f84646 to
4f7b593
Compare
kjohn-msft
approved these changes
Jan 31, 2025
rane-rajasi
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] pr to address bug item 29588036: Prevent excessive logging to disk in runway OS-error conditions
[x] add truncation logic to handle runway logging to disk on machines when there's error, especially network issue. the truncation will cut the message at a safe point at newline and max log content size in byte is set at 32MB to prevent disk space exhaustion on machine
[x] add unit tests