Skip to content

Conversation

@feng-j678
Copy link
Contributor

@feng-j678 feng-j678 commented Jan 22, 2025

[x] pr to address bug item 29588036: Prevent excessive logging to disk in runway OS-error conditions
[x] add truncation logic to handle runway logging to disk on machines when there's error, especially network issue. the truncation will cut the message at a safe point at newline and max log content size in byte is set at 32MB to prevent disk space exhaustion on machine
[x] add unit tests

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.42%. Comparing base (e989b35) to head (12c6895).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/tests/Test_FileLogger.py 98.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   92.26%   92.42%   +0.16%     
==========================================
  Files          96       97       +1     
  Lines       16105    16199      +94     
==========================================
+ Hits        14859    14972     +113     
+ Misses       1246     1227      -19     
Flag Coverage Δ
python27 92.42% <98.93%> (+0.16%) ⬆️
python39 92.42% <98.93%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feng-j678 feng-j678 force-pushed the fix/pkg_mg_excessive_logging branch from f6ae6ab to 422301f Compare January 22, 2025 22:43
@feng-j678 feng-j678 marked this pull request as ready for review January 22, 2025 22:46
@feng-j678 feng-j678 force-pushed the fix/pkg_mg_excessive_logging branch from 6f84646 to 4f7b593 Compare January 23, 2025 23:19
@feng-j678 feng-j678 changed the title Fix/pkg mg excessive logging Fix excessive disk logging Jan 23, 2025
@kjohn-msft kjohn-msft merged commit dc8547e into master Jan 31, 2025
7 checks passed
@kjohn-msft kjohn-msft deleted the fix/pkg_mg_excessive_logging branch January 31, 2025 21:18
@kjohn-msft kjohn-msft mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants