Skip to content

Conversation

@feng-j678
Copy link
Contributor

@feng-j678 feng-j678 commented Nov 10, 2024

[x] add retry logic into check_sudo_status that check sudo for 30 mins at interval of 5min (300sec)
[x] add MAX_CHECK_SUDO_RETRY_COUNT, MAX_CHECK_SUDO_INTERVAL_IN_SEC in constant
[x] add add unit test in test_coremain file to test all possible check sudo cases

image
image
image
image

@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 98.94737% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.23%. Comparing base (530dec2) to head (ba5660a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/tests/Test_Bootstrapper.py 98.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   92.09%   92.23%   +0.14%     
==========================================
  Files          91       92       +1     
  Lines       15953    16035      +82     
==========================================
+ Hits        14692    14790      +98     
+ Misses       1261     1245      -16     
Flag Coverage Δ
python27 92.23% <98.94%> (+0.14%) ⬆️
python39 92.23% <98.94%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feng-j678 feng-j678 marked this pull request as ready for review November 11, 2024 06:16
Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review original comments again

@kjohn-msft kjohn-msft changed the title add retry to check_sudo_status and unit test Add retry to check_sudo_status and unit test Nov 19, 2024
@feng-j678 feng-j678 force-pushed the fix/check_sudo_status_failure branch from 5bb6afc to 4060cc4 Compare November 19, 2024 21:43
kjohn-msft
kjohn-msft previously approved these changes Nov 19, 2024
kjohn-msft
kjohn-msft previously approved these changes Nov 19, 2024
Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

rane-rajasi
rane-rajasi previously approved these changes Nov 23, 2024
@kjohn-msft kjohn-msft enabled auto-merge (squash) November 23, 2024 00:49
@kjohn-msft kjohn-msft merged commit 772ba51 into master Nov 26, 2024
7 checks passed
@kjohn-msft kjohn-msft deleted the fix/check_sudo_status_failure branch November 26, 2024 16:20
@feng-j678 feng-j678 mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants