-
Notifications
You must be signed in to change notification settings - Fork 11
Expanding support for yum install --assumeno cmd to include yum4 #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 90 90
Lines 15700 15760 +60
==========================================
+ Hits 14450 14505 +55
- Misses 1250 1255 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
feng-j678
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline
kjohn-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor inline comments + offline note on type hinting
nikhim-um
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add aarch64 at
| architectures = ['.x86_64', '.noarch', '.i686'] |
Problem statement: Yum 3 and Yum 4 have different output syntax for yum install --assumeno cmd, which used to get dependent packages. Existing implementation was syntax specific, covering only yum 3 scenarios resulting in all dependent packages within yum 4 to NOT be identified.
Since dependent packages were never identified in yum 4, any exclusion rules on these were never applied, causing excluded packages to also get installed.
Fix: Adding capability to read o/p format of the cmd in yum 4.
Tests
Sample of Yum 4:


23 packages were identified:
23 packages installed:
Sample of Yum 3:


Assessment found 63 Critical and Security packages:
64 packages installed: