Skip to content

Conversation

@rane-rajasi
Copy link
Contributor

@rane-rajasi rane-rajasi commented Oct 17, 2024

Problem statement: Yum 3 and Yum 4 have different output syntax for yum install --assumeno cmd, which used to get dependent packages. Existing implementation was syntax specific, covering only yum 3 scenarios resulting in all dependent packages within yum 4 to NOT be identified.
Since dependent packages were never identified in yum 4, any exclusion rules on these were never applied, causing excluded packages to also get installed.

Fix: Adding capability to read o/p format of the cmd in yum 4.

Tests

  • UTs: Added
  • Manual tests: Verified in both yum3 (on RHEL 7.9) and yum4 (CentOS 8.2) versions

Sample of Yum 4:
23 packages were identified:
image
23 packages installed:
image

Sample of Yum 3:
Assessment found 63 Critical and Security packages:
image
64 packages installed:
image

@rane-rajasi rane-rajasi requested review from a team, feng-j678, kjohn-msft and najams and removed request for a team October 17, 2024 13:35
@rane-rajasi rane-rajasi requested a review from najams as a code owner October 17, 2024 13:35
@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.03%. Comparing base (82b15b2) to head (6ed0b32).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/core/tests/library/LegacyEnvLayerExtensions.py 76.92% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   92.03%   92.03%   -0.01%     
==========================================
  Files          90       90              
  Lines       15700    15760      +60     
==========================================
+ Hits        14450    14505      +55     
- Misses       1250     1255       +5     
Flag Coverage Δ
python27 92.03% <92.10%> (-0.01%) ⬇️
python39 92.03% <92.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@feng-j678 feng-j678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline

Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor inline comments + offline note on type hinting

@nikhim-um nikhim-um self-requested a review November 8, 2024 19:32
Copy link
Contributor

@nikhim-um nikhim-um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add aarch64 at

architectures = ['.x86_64', '.noarch', '.i686']
as well

@kjohn-msft kjohn-msft merged commit 234fc37 into master Nov 19, 2024
7 checks passed
@kjohn-msft kjohn-msft deleted the rarane-yumbugfix branch November 19, 2024 17:40
@feng-j678 feng-j678 mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants